When programmatically deleting taxonomy terms, deleting the Path Alias, the $cid is NULL and the following error appears:
[error] Argument 1 passed to Drupal\filecache\Cache\FileSystemBackend::getFilename() must be of the type string, null given, called in /Users/x/websites/projectname/web/modules/contrib/filecache/src/Cache/FileSystemBackend.php on line 171
I propose to do an additional check to check if the cid is not null.
| Comment | File | Size | Author |
|---|---|---|---|
| #2 | filecache-3255584-2.patch | 626 bytes | stijnstroobants |
Show commandsStart within a Git clone of the project using the version control instructions.
Or, if you do not have SSH keys set up on git.drupalcode.org:
changes
Comments
Comment #2
stijnstroobantsComment #3
stijnstroobantsComment #4
pfrenssenThis is in principle a bug in the calling code, but since the core interface
CacheBackendInterface::delete()only documents that$cidshould be a string but does not enforce the type I think it is OK for us to harden this code so the request doesn't crash.Comment #5
pfrenssenComment #8
pfrenssenThanks for the report. I implemented the hardening on all methods that implement the public interface and have a
$cidargument. Since this is indicative of a bug in calling code I made sure to emit an error in the logs including a backtrace so the bug can be discovered and fixed by the developer.Comment #9
pfrenssen