Add PDF file icon

So I can't open that zip archive, if it is even a zip archive.

I've looked at the Tango icon set that Gnome uses because we need to use GPL-compatible icons. I would also like to change the icon folder location so that it's per theme, which makes a lot more sense than having just one icon set for the module, especially for a multisite Drupal setup. So I'd include standard file icons in /modules/filebrowser/icons and then users can override these with icons named correctly in a icons folder in their theme. That would make the most sense and keep the number of steps required to correctly install the module at 1.

I don't plan on updating Filebrowser for 7.x probably for another month. DB:TNG just landed, but it'll be a few weeks for the bugs to be sorted out and the docs to be updated. I plan on adding tests to Filebrowser before I update to 7.x so I can update the tests at the same time.

I can't open that zip file in OS X. I haven't checked out the icons in Tango recently, but they've been doing a good job fleshing out the set.

As for a basic set of icons we definitely need the following:
Text document
Unknown/Default
Image (any type)
PDF
Archive (tgz, zip, rar, etc.)

I think that this issue should just cover those icons for now and the framework for overriding icons. We can expand the set later and with the Unknown/Default icon, it shouldn't be a problem.

Looks like someone already did most of the work grabbing file icons for us:
http://compsci.ca/blog/dotproject-file-icons-mod/

So here's all the supported icons from the Tango Icon Library. 16px by 16px seems the right size. People could override the size by just putting custom icons in their theme.

So, now the question is how do we look up icons for a particular file....determining by MIME-type can't be trusted as that can't be guaranteed to work on a given system. We'll just have to use filetypes, so probably an associative array mapping file type endings (so in the case of a ".tpl.php" file it'd be "php") to the corresponding image. A file by the name of FILETYPE-icon.png would be looked for first and then this array so that new file types could be added just by adding new images and so that the existing defaults could be overridden. With the icons I've attached, I plan on mapping various file endings to the same icon (audio and video is a good example of this).

Here's my first run at this. Supports a bunch of common audio/video/image formats as well as some plaintext, presentation, document, and spreadsheet formats. A folder, parent folder, and default icon have all been provided as well. Extract the icons in /icons in your theme or the filebrowser module directory and apply this patch.

I haven't seen a suitable PDF icon, but I did want to add it. I don't see a need to add it to the mapping and just let the filename be named like a specific file extension.

I think fb-icon-*.png would be acceptable. It's not too long and clearly describes what the icon is for. I haven't seen any news on the icons directoryin 7.x and I'd really like to keep this compatible with that. Maybe we can try to push #138489: named and themed icons along?

You shouldn't need to modify the code at all to override the current defaults, just be more specific, unless you're using the mapping capabilities. I'd like to look into a way to extend this easily, but I think for now it's fine.

I was thinking of adding the executable (exe, sh, bat, etc.) and script icons (php, js, c, python, java), but the ones with Tango are so bland that they really aren't very descriptive and I don't think people would really understand them easily. Do you think we should add them?

that icon would work. The array is only for mapping filetypes to the same icon. If you name your file right the icon will be displayed automatically.

Alright, I'm not adding icons for executables/executable-scripts or PDFs as I don't like the icons for them. I'd renamed the icons so the pattern is "fb-ICONNAME-icon.png".

You don't need to remove the icons directory in the filebrowser directory first of all. The point of the override is that you don't have to configure anything.

So I need more details. You had a file named X and you have an icon named Y that was of the form "fb-XFILEEXTENSION-icon.png" in the /icons directory of your theme.

Please fill in X and Y...

clauded: I think I'm in agreement with BENNYSOFT where the icon is too much an Adobe icon. I think it should be more generic like maybe just say PDF in red on it instead of use the Adobe swoosh. What's the copyright on that swoosh-thing anyways?

I think I prefer the icon in #21 as it's easier to read, so let's go with that one.

As far as the bug, I haven't had a chance to figure it out. I'm moving out to California in a couple of days, so the next couple weeks will be pretty crazy for me.

Let's keep this issue about the PDF icon and create a new one about the bug.

I'v been looking for a way to view *any* icon in directory nodes at all. Right now I don't see any. As this issue seems to be (almost) resolved, is there a chance to get a new release of this module out in the near future, containing all the new code that allows me to configure per-mime-type icons ?
Many thanks,
Stefan

The development branch that this issue pertains to contains this code as that's released nightly. I'll be releasing a final 2.0 version once all issues are resolved, until then use 6.x-2.x-dev.

The way of handling icons changed a bit, now it's easy to add you own. Basicaly when searching an icon for a file, the module first get mime-type XXX/YYY. Icon will be :
module_path/icons/XXX-YYY.png
module_path/icons/XXX.png
theme_path/filebrowser/XXX-YYY.png
theme_path/filebrowser/XXX.png

Please, reopen this issue if this not filling your needs.