This module (among the others) incorrectly assumes that a fieldable entity must be a content entity also. This might be true for the core entities but custom entities can be fieldable without extending the Drupal\Core\Entity\ContentEntityInterface interface. (It is not easy but possible. :) )

Support from Acquia helps fund testing for Drupal Acquia logo

Comments

mxr576 created an issue. See original summary.

mxr576’s picture

mxr576’s picture

Can somebody review this fix? It is in the queue waiting for review for a very long time...

  • joseph.olstad committed 5c97dba on 8.x-2.x authored by mxr576
    Issue #2977747 by mxr576: Not all fieldable entity is a content entity
    
joseph.olstad’s picture

Status: Needs review » Fixed

@mxr576

I have granted you full maintainer priviledges on the all branches. However if you could focus on the 8.x-2.x branch that'd be great.

please review all 8.x-2.x issues and commit /release whatever you see fit.

7.x-2.x/7.x-3.x is in a good spot right now, but 8.x-2.x needs tlc.

Thanks,

joseph.olstad’s picture

Assigned: Unassigned » mxr576
Status: Fixed » Needs review

The tests for the 8.x-2.x branch seem to be complaining more than ever now, not sure if this patch made things worse or if it's other changes upstream.

Please investigate

mxr576’s picture

Thanks for merging this patch and giving me maintainer rights. At this moment, I have enough projects to maintain but if I find some time I'll take a look around this one as well.

Berdir’s picture

Status: Needs review » Fixed
Berdir’s picture

This is fine and doesn't cause the current issues.

mxr576’s picture

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.