Checked some code because of missing $file->description information and was wondering about line 56 of file_entity.theme.inc

  return '<span class="file">' . $icon . ' ' . l($link_text, $url, $options) . '</span>';

$url is not defined in this function. Shouldn't it be $uri ???

CommentFileSizeAuthor
#5 url_file_link-2912054-6.patch626 bytesjoseph.olstad
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

vistree created an issue. See original summary.

joseph.olstad’s picture

joseph.olstad
Primary language French
CreditAttribution: joseph.olstad commented
Version: 7.x-2.4 » 7.x-2.5
Category: Bug report » Support request
Status: Active » Needs review

try release 7.x-2.5 , should be resolved.

vistree’s picture

vistree CreditAttribution: vistree commented

Hi joseph,
the code in 7.x-2.5 is still the same. Where is $url defined in line 56 of file_entity.theme.inc??

joseph.olstad’s picture

joseph.olstad
Primary language French
CreditAttribution: joseph.olstad commented
Category: Support request » Bug report
Status: Needs review » Active
Parent issue: » #2724455: no alt text for file type icon with Download File format

hi @vistree, ok, you are correct, something is not right here.

not sure yet how to fix this.

joseph.olstad’s picture

joseph.olstad
Primary language French
CreditAttribution: joseph.olstad commented
Status: Active » Needs review
FileSize
url_file_link-2912054-6.patch626 bytes

  • joseph.olstad authored c77fb18 on 7.x-2.x 
    Issue #2912054 by joseph.olstad, vistree: $url in function...

  • joseph.olstad authored c77fb18 on 7.x-3.x 
    Issue #2912054 by joseph.olstad, vistree: $url in function...
joseph.olstad’s picture

joseph.olstad
Primary language French
CreditAttribution: joseph.olstad commented
Status: Needs review » Fixed
vistree’s picture

vistree CreditAttribution: vistree commented

Hi Josef - very cool. Thanx!

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.