As pointed out in #611294-99: Refine permissions for Field UI, the change to Drupal core in that issue will cause some File Entity users to see "Manage fields" and "Manage display" links in the admin UI that give them "access denied" when they click on it.

Here's a patch that fixes that. It's written in such a way that it should work regardless of whether Drupal core has been updated to include that change or not.

Support from Acquia helps fund testing for Drupal Acquia logo

Comments

David_Rothstein created an issue. See original summary.

David_Rothstein’s picture

Status: Active » Needs review
FileSize
697 bytes

Here is the patch.

Dave Reid’s picture

Status: Needs review » Fixed

Seems straightforward to me and tested, so committed to 7.x-1.x. Thanks!

Dave Reid’s picture

Status: Fixed » Needs work

Tests started failing and we missed this since the upstream core issue hadn't been committed yet.

Dave Reid’s picture

Status: Needs work » Needs review
FileSize
553 bytes

Status: Needs review » Needs work

The last submitted patch, 6: 2735841-fix-tests.patch, failed testing.

Dave Reid’s picture

Added permission at the wrong place.

Dave Reid’s picture

Status: Needs work » Needs review

Status: Needs review » Needs work

The last submitted patch, 8: 2735841-fix-tests.patch, failed testing.

The last submitted patch, 8: 2735841-fix-tests.patch, failed testing.

Dave Reid’s picture

Status: Needs work » Needs review
FileSize
606 bytes

And then I uploaded the wrong patch. :/

Status: Needs review » Needs work

The last submitted patch, 12: 2735841-fix-tests.patch, failed testing.

  • Dave Reid committed b927a53 on 7.x-2.x
    Issue #2735841 by Dave Reid: Fixed tests needed the new "administer...
Dave Reid’s picture

Status: Needs work » Fixed

Will be fixing the PHP 5.6 failures separately.

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.