Early Bird Registration for DrupalCon Portland 2024 is open! Register by 23:59 PST on 31 March 2024, to get $100 off your ticket.
How to reproduce:
- Enable private files
- Upload a private file
- Enable file_entity
- Go to the edit page for the file and attempt to save it
Results:
Expected Results:
- If the file uses a missing stream wrapper: ???
- If the file uses a valid stream wrapper but not assigned to the file type: show a warning and a disabled radio for the current scheme?
Maybe a better question, is why file types need to care about schemes at all? This seems to complicate things greatly.
Comment | File | Size | Author |
---|---|---|---|
#11 | file_entity-edit_file_with_no_scheme-1979804-11.patch | 1.52 KB | pbuyle |
#8 | file_entity-edit_file_with_no_scheme-1979804-7.patch | 1.45 KB | pbuyle |
#7 | 6AqOwrJ.png | 51.85 KB | Dave Reid |
Comments
Comment #1
Dave ReidAlternatives, should the file type schemes only matter when creating new files?
Comment #2
Dave ReidRelated: #1979832: Remove schemes from file types
Comment #3
Dave ReidI will clarify, I don't think we should remove the scheme selection from the upload form. That seems to be a function that lots of people would actually use. I just don't think there should be any type of association between file type and schemes.
Comment #4
Dave ReidThe second expected result would be solved by #1979832: Remove schemes from file types
Comment #5
Dave ReidReducing scope now that #1979832: Remove schemes from file types is committed.
Comment #6
Dave ReidMoving to beta blocker
Comment #7
Dave ReidComment #8
pbuyle CreditAttribution: pbuyle commentedI tried to reproduce (manually and using simpletest, see attached path) the issue following the steps in the issue without success (ie. I can edit the file alright).
So the issue is either already fixed, or we need to figure another way to reproduce it.
Comment #9
pbuyle CreditAttribution: pbuyle commentedComment #10
pbuyle CreditAttribution: pbuyle commentedAfter discussion with Dave, the missing step is to disable private files before the edit. I'll work on that.
Comment #11
pbuyle CreditAttribution: pbuyle commentedDisabling private files with
variable_del('file_private_path');
right before enabling the File Entity module in the test case cause the test to fail because of the following error:These three are to be expected for a file with a missing file wrapper.
The file entity can still be edited, so the issue is no longer a beta blocker.
Comment #12
Devin Carlson CreditAttribution: Devin Carlson commentedSending to the testbot to review the failure in #11.