Early Bird Registration for DrupalCon Portland 2024 is open! Register by 23:59 PST on 31 March 2024, to get $100 off your ticket.
Ctools page_manager supports the ability for modules to expose a methodology for overriding paths that module may provide. In this case, page_manager's ability to already handle media entities out of the box would be complimented if the default media/%media path were overrideable. This is pretty easy to do, and wouldn't add any dependencies, we'd simply get the benefit of the plugin if page_manager is installed.
Patch coming.
Comment | File | Size | Author |
---|---|---|---|
#8 | 1058098_1.patch | 5.85 KB | EclipseGc |
#1 | 1058098.patch | 5.78 KB | EclipseGc |
Comments
Comment #1
EclipseGc CreditAttribution: EclipseGc commentedComment #2
EclipseGc CreditAttribution: EclipseGc commentedComment #4
EclipseGc CreditAttribution: EclipseGc commentedUhh... why doesn't that apply?
Comment #5
aaron CreditAttribution: aaron commented#1: 1058098.patch queued for re-testing.
Comment #6
aaron CreditAttribution: aaron commentedfor consistency and ease of uninstallation:
+ if (variable_get('media_media_view_disabled', TRUE)) {
and
+ variable_set('media_media_view_disabled', TRUE);
might consider using media's namespaced variable functions:
media_variable_get('media_view_disabled'); and media_variable_set('media_view_disabled', TRUE); and setting the default to TRUE.
Comment #8
EclipseGc CreditAttribution: EclipseGc commentedok, I think this should fix the patch.
Comment #9
EclipseGc CreditAttribution: EclipseGc commentedMaintaining this as a branch in my own sandbox for media module right now, you can address it here, it will make merging much easier whenever you get around to it:
git clone --branch 1058098 http://git.drupal.org/sandbox/eclipsegc/1081502.git
Comment #10
JacobSingh CreditAttribution: JacobSingh commentedIs this still relevant IIRC, you got commit access and added this.
Comment #11
EclipseGc CreditAttribution: EclipseGc commentedI didn't actually add it yet, but I will... so yes it's relevant, but I'm not sure I need anyone to review it at this point.
Comment #12
jeffwidman CreditAttribution: jeffwidman commentedsub
Comment #13
Shadlington CreditAttribution: Shadlington commentedWas this committed yet?
Comment #14
EclipseGc CreditAttribution: EclipseGc commentedIt was not, I was told a big change to media is in the pipes and that I might as well hold off.
Comment #15
FrequenceBanane CreditAttribution: FrequenceBanane commentedso, what's up now ?
Comment #16
Dave ReidThis is definitely 2.x territory now.
Comment #17
Dave ReidThis also needs to be moved to the file_entity as it's responsible for the file/%file paths.
Comment #18
Dave ReidMarking this as a duplicate of #1564456: Provide support for Page manager, Panels, and Panelizer which has much more updated work, even though I should have just continued with this issue, sorry. I'll make sure EclipesGc gets commit credit mention.
Comment #19
EclipseGc CreditAttribution: EclipseGc commentedOh thanks lol. I appreciate :-D