I'm using this module on a multilingual site, and this line of code in file_chooser_field.js caused me some issues as the submit button value had been translated from 'Upload' to 'subir' (Spanish).

$('input.form-submit[value=Upload]', $parent).mousedown();

Naturally this meant the actual submit function never fires for local files.

Incoming patch to run this through Drupal.t() to support those using this with multiple languages.

Support from Acquia helps fund testing for Drupal Acquia logo

Comments

aaron.ferris created an issue. See original summary.

aaron.ferris’s picture

aaron.ferris’s picture

Status: Active » Needs review

Status: Needs review » Needs work

The last submitted patch, 2: file-chooser-field-submit-value-translate-2777779.patch, failed testing.

vijaycs85’s picture

Status: Needs work » Needs review
FileSize
0 bytes

Just to confirm the issue is not because of the patch....

Status: Needs review » Needs work

The last submitted patch, 5: 2777779-empty.patch, failed testing.

vijaycs85’s picture

Status: Needs work » Needs review
FileSize
289 bytes

Another try

Status: Needs review » Needs work

The last submitted patch, 7: file_chooser_field-2777779-7.patch, failed testing.

  • vijaycs85 authored e70d3387 on 7.x-1.x
    Issue #2777779 by vijaycs85: 'Browse' option not firing file upload on...

  • vijaycs85 authored 9adcfbf9 on 7.x-1.x
    Issue #2777779 by vijaycs85, aaron.ferris: 'Browse' option not firing...
aaron.ferris’s picture

Committed and pushed to 7.x-1.x

aaron.ferris’s picture

Status: Needs work » Fixed
aaron.ferris’s picture

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.