It appears that there are several issues concerning the pane title when one opts to use panelizer to control the display of a fieldable panel pane bundle.
To start, setting the title setting to 'no title' is not respected (still outputs the pane title with standard formatting).
Secondly, using the 'title' field content type does not work either.
Thus, what I'm getting with these settings:
Title:No title
field:title
field:other_field
I'm getting:
Title
I hope that makes sense? It's very different from the behavior that I'm getting using panelizer with other entity types. I'm using semantic panels, but I cannot define a default semantic panel style for a specific FPP bundle (wouldn't that be nice?) thus I'm looking to panelize the default display to achieve this effect, so one does not have to style each individual fpp pane as its created.
Comment | File | Size | Author |
---|---|---|---|
#9 | 2015383-panelizer-title-lost-8.patch | 1.24 KB | fubhy |
Comments
Comment #1
rerooting CreditAttribution: rerooting commentedIt also might be worth mentioning that I've applied #1588882: Use title for entity label when admin_title isn't present
Comment #2
merlinofchaos CreditAttribution: merlinofchaos commentedThis patch is completely untested and might need some tweaks, but it should be close to fixing this.
Comment #3
rerooting CreditAttribution: rerooting commentedHmm...no dice... I'll try this in a sandbox and see if I can't isolate it. I'm wondering if the fact that I'm using panopoly has anything to do with it. The code certainly looks like it should work!
Comment #4
rerooting CreditAttribution: rerooting commentedOk, tested it in a vanilla install, still not working. Using Panelizer, FPP, Panels, Ctools, etc all --dev from drush. No panoply this time (panopoly_magic messes with FPP titles a bit I think?)
It looks like both load and render are doing their job from the devel end of things.
hide_title is set to 1, and the content wants to show fieldable_panels_pane:title, however the panelized content is rendering blank, and the pane title is still showing in the default way.
heres the #panelizer_content array if you are interested:
#panelizer_content (Array, 4 elements)
content (String, 437 characters )
no_blocks (Boolean) FALSE
classes_array (Array, 0 elements)
title (String, 0 characters )
There are a few other FPP<>Panelizer bugs that I will report in other issues! Let me know how else I can help, thanks a bunch!
Comment #5
merlinofchaos CreditAttribution: merlinofchaos commentedOh, the code is checking !empty() on the title. Change that to isset().
Comment #6
rerooting CreditAttribution: rerooting commentedI tried fiddling around with the patch - it seems that it will make titles dissapear properly if they are set to no title, however the extra_field fieldable_panels_pane:title still isn't displaying in the content at all when the panelizer default template is set to no title. I'll see if I can't extend this patch to make it do that as well.
Comment #7
fubhy CreditAttribution: fubhy commentedRe-uploading fixed patch. I can confirm that this works with isset() now.
Comment #9
fubhy CreditAttribution: fubhy commentedSorry, screwed up the patch
Comment #10
Peacog CreditAttribution: Peacog commentedThe patch in #9 works for me. Thank you.
Comment #11
fubhy CreditAttribution: fubhy commentedRTBC then. ;)
Comment #12
magicmyth CreditAttribution: magicmyth commentedJust tested this patch as well. Makes FPP and Panelizer work as expected now. Thanks!
Comment #13
DamienMcKennaComment #14
DamienMcKennaThis patch doesn't affect the title when viewing an FPP entity on its own that is controlled via Panelizer, that uses the CTools entity_field_extra.inc plugin.
Comment #15
DamienMcKennaTest scenario:
Changing this back to Needs Work.
Comment #16
DamienMcKennaNot going to do this in 1.6.
Comment #17
DamienMcKenna