Come together with the global Drupal community in Rotterdam, 28 Sept – 1 Oct 2026. Sessions, contribution, connection, and Early Bird savings until 8 June.
I tried fixing the 8.3.x tests, or at least I wanted to do that. Didn't really manage to.
What I did was:
Convert web tests to browser tests
Add / fix comments
Adhere more strictly to 80 chars rules
Convert some of the arrays to short notation (Should be only the ones on lines I had already touched)
Fix unit test missing abstract method error.
Remove most of the t function calls, the tests don't have translations enabled, so no need to add that overhead
Convert some of the deprecated calls to BTB calls.
Remove at least some of the randomString calls, using random strings in tests could lead to random fails that are almost impossible to reproduce and debug.
Removed the strict config checking in ManageDisplayTest, this needs to be fixed, but getting green tests is prio #1 I think.
Please help me figure out how to fix the migrate tests, it's the part of Drupal I know the least about and I have no idea why the tests are failing there.
I'm ending my day for now, but I'll come back to this issue over the weekend.
Comments
Comment #2
borisson_I tried fixing the 8.3.x tests, or at least I wanted to do that. Didn't really manage to.
What I did was:
tfunction calls, the tests don't have translations enabled, so no need to add that overheadIt's also one of the couple of places where we as devs can add some "personality" to tests. (for example, I added the titles of one of my favorite albums to the search api codebase like that a while ago: http://cgit.drupalcode.org/search_api/tree/tests/src/Functional/HooksTes...) ;)
Please help me figure out how to fix the migrate tests, it's the part of Drupal I know the least about and I have no idea why the tests are failing there.
I'm ending my day for now, but I'll come back to this issue over the weekend.
Comment #4
borisson_No idea why that's being tested to 8.1.x. should be 8.3.x.
Comment #5
borisson_Comment #6
nils.destoop commentedThx for the patch. I researched the remaining errors, and succeeded in it. Stupid dependencies :). Tests are now green again after the commit :)
Comment #8
nils.destoop commented