Problem/Motivation

Wrong name for "JavaScript".

Proposed resolution

Fix the naming.

CommentFileSizeAuthor
#2 javascript_JavaScript-2833704-2.patch1.6 KBvagelis-prokopiou
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

Vagelis created an issue. See original summary.

vagelis-prokopiou’s picture

vagelis-prokopiou CreditAttribution: vagelis-prokopiou as a volunteer commented
Status: Active » Needs review
FileSize
javascript_JavaScript-2833704-2.patch1.6 KB

Status: Needs review » Needs work

The last submitted patch, 2: javascript_JavaScript-2833704-2.patch, failed testing.

SpartyDan’s picture

SpartyDan CreditAttribution: SpartyDan commented
Priority: Normal » Minor
Status: Needs work » Reviewed & tested by the community

This is a trivial issue as it only addresses a case change in the word JavaScript. Marking as RTBC so that nobody else needs to use their time to look at it.

@vagelis I understand that this patch makes the module more correct but as it does not change the grammar nor the functionality of the module it does not seem to rise to the level of necessary IMO.

vagelis-prokopiou’s picture

vagelis-prokopiou CreditAttribution: vagelis-prokopiou as a volunteer commented

@SpartyDan, good point. Good correction. The priority was overlooked by me. Thanx.

nils.destoop’s picture

nils.destoop CreditAttribution: nils.destoop as a volunteer and commented
Status: Reviewed & tested by the community » Fixed

Thx for the patch. Committed it to dev

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.