No group effects after 8.x-1.0-rc6 as it did in 8.x-1.0-rc4 [#2831356]

8.x-1.0-rc6 seems to break group effects for content type displays.

I have one group set as bellow:

third_party_settings:
  field_group:
    group_o_ft:
      children:
        - field_o_ft_gale
        - field_o_ft_cate
        - field_o_ft_esob
        - field_o_ft_esli
        - field_o_ft_lote
        - field_o_ft_trec
        - field_o_ft_exte
        - field_o_ft_banc
        - group_o_ft_mf
      parent_name: ''
      weight: 1
      label: 'Ficha Técnica'
      format_type: html_element
      format_settings:
        label: 'Ficha Técnica'
        element: section
        show_label: true
        label_element: h2
        attributes: ''
        effect: blind
        speed: fast
        id: ft
        classes: 'group l1'

With 8.x-1.0-rc4, the above outputs the following HTML:

<h2 class="field-group-toggler" id="Ficha_Técnica"><a class="field-group-title" href="#">Ficha Técnica</a></h2>

But after 8.x-1.0-rc6, we now have:

<h2 class="field-group-toggler" id="Ficha_Técnica">Ficha Técnica</h2>

As there's no 'a' element, there's no way to handle the colapse effect for a group. Also, if one use the anchor element to style stuff or add behaviors, this is now broken.

Comments

Comment #1

29 November 2016 at 08:50

denydias created an issue. See original summary.

Comment #2

denydias CreditAttribution: denydias as a volunteer commented 29 November 2016 at 08:59

Issue summary:

View changes

Comment #3

denydias CreditAttribution: denydias as a volunteer commented 29 November 2016 at 09:01

Issue summary:

View changes

Comment #4

snsblvd CreditAttribution: snsblvd commented 30 November 2016 at 20:28

I do have a similarly issue, that after upgrading to the rc6 (from rc4) my theme is not working anymore correct. but I do have still the a element, but my h3 is missing some needed ids and classes.

Example:

Not working (8.x-1.0-rc6):

<h3 class="field-group-format-toggler accordion-item">
  <a href="#">CV</a>
</h3>

http://scholarly.rockheavy.org/students/ipsum-risus

Working (8.x-1.0-rc4):

<h3 class="field-group-format-toggler accordion-item ui-accordion-header ui-state-default ui-corner-all ui-accordion-icons" role="tab" id="ui-id-1" aria-controls="ui-id-2" aria-selected="false" aria-expanded="false" tabindex="0"><span class="ui-accordion-header-icon ui-icon ui-icon-triangle-1-e"></span>
  <a href="#">CV</a>
</h3>

http://scholarly2.rockheavy.org/students/ipsum-risus

Comment #5

14 January 2017 at 22:45

zuuperman committed 71e0fba on 8.x-1.x

Issue #2831356: No group effects after 8.x-1.0-rc6 as it did in 8.x-1.0-...

Comment #6

nils.destoop CreditAttribution: nils.destoop as a volunteer and at Wunder commented 14 January 2017 at 22:45

Status:

Active

» Fixed

This should now be fixed in dev

Comment #7

denydias CreditAttribution: denydias as a volunteer commented 14 January 2017 at 23:23

Tks, @zuuperman! Is there a expected release date for rc7? Is it going to include this fix?

Comment #8

snsblvd CreditAttribution: snsblvd as a volunteer commented 16 January 2017 at 19:47

..for me it seems not to be fixed. I made a drush up field_group-8.x-1.x-dev got still the same result. My field group looks like this. So I guess its a separated issue with the type accordion. You want a new issue? Thanks for your help!

third_party_settings:
  field_group:
    group_mt_details:
      children:
        - group_mt_cv
        - group_mt_supervisors
        - group_mt_contact_info
        - group_mt_websites
        - group_mt_recent_publications
      parent_name: ''
      weight: 6
      label: Details
      format_type: accordion
      format_settings:
        label: Details
        effect: bounceslide
        id: ''
        classes: ''
    group_mt_cv:
      children:
        - field_mt_cv
      parent_name: group_mt_details
      weight: 116
      label: CV
      format_type: accordion_item
      format_settings:
        label: CV
        formatter: closed
        id: ''
        classes: ''
...