In some weird way, the patch from https://www.drupal.org/node/2689501 seems to have broken the display of comments on a site that I'm working on.

Can't tell you how or why. Just that if I checkout 68020f6f, they works. If I checkout 48da6349, they doesn't.

Sorry that I can't be more helpful ATM.

Comments

tlyngej created an issue. See original summary.

tlyngej’s picture

tlyngej CreditAttribution: tlyngej at Annertech commented
Issue summary: View changes
claudiu.cristea’s picture

claudiu.cristea
Primary language Romanian
Location Arad 🇷🇴
CreditAttribution: claudiu.cristea at Webikon for European Commission and European Union Institutions, Agencies and Bodies commented
Priority: Normal » Critical

I confirm the but. It's Critical

claudiu.cristea’s picture

claudiu.cristea
Primary language Romanian
Location Arad 🇷🇴
CreditAttribution: claudiu.cristea at Webikon for European Commission and European Union Institutions, Agencies and Bodies commented

#2689501: Does not work with blocks broke it but I marked that as Fixed so the bug should be fixed here.

claudiu.cristea’s picture

claudiu.cristea
Primary language Romanian
Location Arad 🇷🇴
CreditAttribution: claudiu.cristea at Webikon for European Commission and European Union Institutions, Agencies and Bodies commented
Related issues: +#2689501: Does not work with blocks
claudiu.cristea’s picture

claudiu.cristea
Primary language Romanian
Location Arad 🇷🇴
CreditAttribution: claudiu.cristea at Webikon for European Commission and European Union Institutions, Agencies and Bodies commented

Probably is duplicate of #2825389: Hook switch breaks ECK render (?)?

@tlyngej, can you test the patch from there with HEAD to see if works?

nils.destoop’s picture

nils.destoop CreditAttribution: nils.destoop as a volunteer and at Wunder commented
Status: Active » Fixed

I reverted the commit that breaks rendering.

tlyngej’s picture

tlyngej CreditAttribution: tlyngej at Annertech commented

@claudiu.cristea

Since this has been "fixed", would you still want me to test the patch?

claudiu.cristea’s picture

claudiu.cristea
Primary language Romanian
Location Arad 🇷🇴
CreditAttribution: claudiu.cristea at Webikon for European Commission and European Union Institutions, Agencies and Bodies commented

@tlyngej, no. The root cause was reverted. Thanks

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.