Hook switch breaks ECK render (?) [#2825389]

I haven't tracked down why, but have identified by bisecting that something in http://cgit.drupalcode.org/field_group/commit/?h=8.x-1.x&id=48da634956a8... is breaking unrelated entity renders (specifically for me, image fields within ECK rendered entities are not displaying) -- possibly has to do with switching to hook `entity_view_alter` from `entity_display_build_alter`?

I'm using field groups only for the form display so front end shouldn't be touched, but in this case it is.

Comment	File	Size	Author
#4	field_group-check-for-empty-render-key-2825389-4.patch	467 bytes	ahebrank
#3	field_group-check-for-empty-render-key-2825389-3.patch	466 bytes	ahebrank

Support from Acquia helps fund testing for Drupal Acquia logo

Comments

Comment #1

7 November 2016 at 13:43

ahebrank created an issue. See original summary.

Comment #2

ahebrank CreditAttribution: ahebrank at NewCity commented 7 November 2016 at 14:28

Issue summary:

View changes

Comment #3

ahebrank CreditAttribution: ahebrank at NewCity commented 7 November 2016 at 15:15

File	Size
field_group-check-for-empty-render-key-2825389-3.patch	466 bytes

Here's a quick fix for my situation -- makes sure that there are field groups to add before appending the pre_render hook.

Comment #4

ahebrank CreditAttribution: ahebrank at NewCity commented 7 November 2016 at 15:25

File	Size
field_group-check-for-empty-render-key-2825389-4.patch	467 bytes

Oops, missed a parenthesis.

Comment #5

claudiu.cristea

Romanian

Arad 🇷🇴

CreditAttribution: claudiu.cristea at Webikon for European Commission and European Union Institutions, Agencies and Bodies commented 8 November 2016 at 11:00

Is this also the source cause for #2825434: Comment display is broken after update? Would this solve also that? If yes, that should be closed as duplicate of this and this is Critical.