I created a "horizontal" TABS with several TAB.
If access the account using Chrome browser, it looks fine. However if I access the account using Firefox or IE browser, the LABEL of the TAB are not displayed. (see picture attached).
On "vertical" TABS it looks fine.

Support from Acquia helps fund testing for Drupal Acquia logo

Comments

British-Link created an issue. See original summary.

Zeshin’s picture

I noticed the same horizontal tabs issue, except I'm only seeing it in Microsoft Edge and IE. At first I thought it might be something weird about the way the browsers interpret the CSS, but when I checked the console I found that the actual tab title text itself wasn't getting populated into the HTML. For example if I have a horizontal tab titled "Info", in both Chrome and Firefox the html shows as <strong>Info</strong>, but in Edge it shows as just <strong></strong>. Weird.

ozin’s picture

Hi guys, I can't reproduce this bug, I think it related to browser version. However try this patch.

Zeshin’s picture

Unfortunately the patch didn't resolve the issue. However, I checked that tabs.js file and added some dummy text right in between the <strong></strong> tags just to confirm that code was the affected area, and my dummy text showed up just fine in all browsers. Strangely the tab title itself, contained in the variable settings.title, only showed up in Firefox and Chrome; in Edge/IE the tab title still didn't show. So, I suspected the variable settings.title might actually for some odd reason be an empty string, and confirmed it in Edge with a javascript test. I wondered if maybe something was wrong with the settings object itself, and did a quick check to see if the settings.details.attr('id') variable referenced a few lines earlier produced a valid value, which it did. So for some odd reason in Edge the variable settings.title alone is turning up as an empty string. Maybe it's getting overridden somewhere, or it isn't getting set correctly, or the theme function's somehow called before the value's populated, or Edge is somehow hiccuping, I'm not really sure.

nils.destoop’s picture

Status: Active » Fixed

Looks like this is fixed when #2743127: Add core/drupal.collapse dependency got committed. My tab was empty, after applying that patch, it was ok. The patch adds dependencies, those dependencies are executed first. Before the patch, fieldgroup came to early.

Zeshin’s picture

Yep that fixed it, thanks zuuperman!

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.

SteffenR’s picture

I still have the problem in firefox browser.
Actual version of field_group is commit hash #68020f6f4b185c5989b70272ac32177d4c42b882

I have not tried the patch from #3, but as zuuperman already mentioned, the issue should be fixed in #2743127.

SteffenR