Status:
grendzy and raspberryman closed the last two critical tickets:
- #1084268: Exception: Invalid field name given. in FieldCollectionItemEntity
- #1714478: Cant use time "24:00" or "00:00" in dateformat field after upgrade to D7.15
Of the 20 major tickets, they found only one that is a release blocker and needs attention:
#1281974: Missing bundle property on entity - related to translations - That ticket needs a good 2 hours of curation to clear the patches up and improve the steps to reproduce, then an additional scope on the fix once the patches have been reviewed.
#1316162: Support content translation and host entity cloning - Although this is a major and important ticket, it is more of a feature request and shouldn't be a v1.0 release blocker.
2 other issues that I are close to being RTBC and help resolve serious bugs in FC.
- #2000690: Deleting revisions via node_revision_delete wrongly deletes entire field collection
- #1807460: Field collection doesn't play nice with workbench moderation (patch)
#1344672: Field Collection: Field translation (entity_translation) support. - See #12 for Entity Translation
Original post:
Hey there, this module is used by drupal.org, and as part of the https://drupal.org/community-initiatives/drupalorg/drupal7 D7 Upgrade Initiative, we need to get it to a stable 1.0 release prior to launch.
What will it take to push a release of this module out the door before Oct 30th, 2012? Let's use this issue to investigate and generate a bullet-point list of things that need to happen (or a list of links to other issues).
Comments
Comment #1
twardnw CreditAttribution: twardnw commented#1714478: Cant use time "24:00" or "00:00" in dateformat field after upgrade to D7.15 - I do not believe this to be an issue with field_collection
#1084268: Exception: Invalid field name given. in FieldCollectionItemEntity - this needs input from the maintainers on the direction to take with the module
Comment #2
raspberryman CreditAttribution: raspberryman commentedTried, but could not reproduce #1281974: Missing bundle property on entity - related to translations. See my tests at: http://drupal.org/node/1281974#comment-6714240
At this point, I don't see any release blockers.
Comment #3
Senpai CreditAttribution: Senpai commentedIt looks like Field Collection has no criticals left, and is now ready for a 1.0 release. Let's make it so.
Comment #4
kscheirerWe have 16 active major bug reports - are any of these release blockers?
Comment #5
drummThis isn't actually a blocker. A 1.0 would be great, but we can live with beta5 if we need to.
Comment #5.0
drummUpdating v1.0 release status
Comment #6
klonosComment #7
HyperGlide CreditAttribution: HyperGlide commentedComment #8
mgiffordOr for that mater a stable Beta 6. It's been over a year since the last release. This isn't a best practice as far as I am concerned #2186377: Highlight projects that follow Best Practices
It would be great if this could happen. There are a number of other issues that seem close:
@tim.plunkett - You've weighed in on some of the issues I've brought up around providing incentives for contrib modules & issue queues (Thanks for this btw).
What changes could be made to d.o to make this module easier to maintain for you?
EDIT: There are 56k sites using this module. There have to be some means to make it a priority for this to be more actively maintained.
Comment #9
jmuzz CreditAttribution: jmuzz commentedI think d.o is good and any change to it will not likely make this module easier to maintain. It is just a complicated module that needs to interact with a lot of other things. For example, compare the number of installs vs. reported issues in field_collection and imce_wysiwyg.
With so much work happening on D8 now it seems unlikely to me for the D7 version of this module to receive significant additional efforts from a new source, but as the D8 release approaches I think it will be easier to attract talent so long as the module remains relevant and is not replaced by solutions such as entity reference.
Comment #10
mgifford@jmuzz - you might be right. However, we've got another 3-4 years of support for Drupal 7. Maybe more.
Fixing these issues for D7 is important for 99,720 sites right now. With that many users, we should be able to find a way to make it a priority to address this critical problem.
Many of the outstanding issues have already been fixed it seems. It just needs to be made a priority.
Comment #11
jmuzz CreditAttribution: jmuzz commentedIt would be nice if there was a pager at the top of the issue comments so I don't need to scroll to the bottom of all 300 of them to find it.
Comment #12
fagoYeah, many users are using it - that doesn't necessarily mean it's release ready. E.g., there is still #1344672: Field Collection: Field translation (entity_translation) support. open which I'd conside mandatory for a 1.0 release: One would expect the module to support the features of field API, i.e. revisions and translations. We managed the get the former done, but the latter is not done yet. (Not speaking of stability of those features even.).
Comment #13
Georgique CreditAttribution: Georgique commentedAgree to @fago #12
Comment #14
mgiffordOk, adding that to the summary. Doing minor formatting there too.
Comment #15
DamienMcKennaStandardized the issue title.
Comment #16
joseph.olstadLooks like we're close to a 7.x-1.0 release, only these two issues are remaining and they've been marked 'needs review' for quite some time.
#1281974: Missing bundle property on entity - related to translations
and
#1316162: Support content translation and host entity cloning
Comment #17
jmuzz CreditAttribution: jmuzz commentedThe issues mentioned by @joseph.olstad should be taken care of.
Don't forget #2339023: Migrate field collection revisions supported in beta4 to be up to date
Comment #18
DamienMcKennaComment #19
joseph.olstadnot that I want to delay this upgrade, we might optionally also want to include
#2855148: Update Entity translation API usage in Field collection
and insane performance gains:
#1427158: Use field_collection_field_formatter_prepare_view to increase performance by 50%
Comment #20
Liam MorlandComment #21
Liam MorlandComment #22
joseph.olstadPHP 7.2 compatibility, that is important, someone should take this and run with it.
Comment #23
Liam MorlandWe just need RTBC for #3009729: Notice: Only variables should be passed by reference in PHP 7.1. The other tickets are already RTBC. Then we need a maintainer to commit.
Update: RTBC complete.
Comment #24
Chris Matthews CreditAttribution: Chris Matthews commented@joseph.olstad commented in #19
Can we decide if this particular should be included in the full 7.x-1.0 release or not? If not, if would be nice for a maintainer could tag the full release.
Comment #25
joseph.olstadNo longer relevant:
yes please include that patch. It's essentially a one line patch if ignoring the hook_requirements (1.0 version of entity_translation) ONLY CHECKS REQUIREMENTS IF using entity_translation. Uses the updated api call (the optimal one for the 1.0 release of entity_translation)#2855148-10: Update Entity translation API usage in Field collectionComment #26
joseph.olstadRTBC
Comments #19 , #24 and #25 are no longer relevant. Approach to translation has changed since that issue was raised.
Comment #27
ram4nd CreditAttribution: ram4nd as a volunteer commentedIf https://www.drupal.org/project/field_collection/issues/2833061 is resolved. And there are no issues in a while. The release will be made.
Comment #28
vibrasphere CreditAttribution: vibrasphere commentedWhy does it take longer to push a single module to stable release than entire Drupal core from 7 to 8?
Using this module since 2012 never had a problem. 1.7 mil downloads, 170k reporting using.
Comment #29
joseph.olstad@vibrasphere, good point. seeing as #2833061: Exception: The host entity cannot be changed. in FieldCollectionItemEntity->updateHostEntity() is resolved, there's nothing holding back a release, any new request would be just trepidation.
Comment #30
Chris Matthews CreditAttribution: Chris Matthews commentedI just sent an email to @ram4nd, @jmuzz, @RenatoG and @nedjo via their contact forms to see if someone could tag a 7.x-1.0 release.
Comment #31
ram4nd CreditAttribution: ram4nd as a volunteer commentedRelease made, when d.org will process it, it will be shown on the modules page.
Comment #32
joseph.olstadHi @Ram4nd, thanks for this. I do have one really easy request, please set the default test for issues and commits to php 7.2.x and please add php 7.3.x testing on commits.
Thanks!