Function libxml_disable_entity_loader is deprecated on PHP8 [#3319597]

Problem/Motivation

Function libxml_disable_entity_loader throws deprecation warning on PHP8.

Steps to reproduce

Install Feeds and this module in D7.
Create a feed with ~~processor~~ parser, "XPath XML parser"
Run the import
Watchdog shows warning
Deprecated function: Function libxml_disable_entity_loader() is deprecated in FeedsXPathParserBase->errorStop() (line 598 of feeds_xpathparser/FeedsXPathParserBase.inc).

Proposed resolution

Fix it the same way they did on feeds_ex by adding check for PHP version: https://www.drupal.org/project/feeds_ex/issues/3257376

Remaining tasks

~~I will supply a patch shortly.~~
Patch attached.

Comment	File	Size	Author
#2	feeds_xpathparser-3319597-libxml_disable_entity_loader_deprecated-php8.patch	952 bytes	darkodev

Issue fork feeds_xpathparser-3319597

Show commands

Start within a Git clone of the project using the version control instructions.

Add & fetch this issue fork’s repository

Or, if you do not have SSH keys set up on git.drupalcode.org:

Add & fetch this issue fork’s repository

3319597-function-libxmldisableentityloader-is changes, plain diff MR !1
Check out this branch for the first time

Check out existing branch, if you already have it locally

About issue forks

Comments

Comment #1

7 November 2022 at 23:31

darkodev created an issue. See original summary.

Comment #2

darkodev commented 7 November 2022 at 23:34

Status	File	Size
new	feeds_xpathparser-3319597-libxml_disable_entity_loader_deprecated-php8.patch	952 bytes

Comment #3

darkodev commented 7 November 2022 at 23:35

Issue summary:

View changes

Comment #4

darkodev commented 7 November 2022 at 23:36

Issue summary:

View changes

Comment #5

klausi

he/him||they/them

German

🇦🇹 Vienna

commented 4 July 2023 at 15:09

Status:

Active

» Reviewed & tested by the community

Makes sense, thanks!

Comment #6

fredonia_webteam commented 17 January 2024 at 21:02

Hello,

I am getting this error after upgrading to PHP8.1. Using version 7.x-1.1 with feeds module 7.x-2.0-beta6. Any update on getting this patch into a release?

Thank you!