Is this a known issue with PHP 7?
When trying to access feeds configuration or a Feature that is tracking feeds tamper configuration I get:

Fatal error: Redefinition of parameter $source in /Users/daniel/sites/myproject/wwwroot/sites/all/modules/contrib/feeds_tamper/plugins/default_value.inc on line 36

Call Stack
#	Time	Memory	Function	Location
1	0.0006	365592	{main}( )	.../index.php:0
2	0.3832	37007112	menu_execute_active_handler( )	.../index.php:21
3	0.3843	37099040	drupal_get_form( )	.../menu.inc:527
4	0.3843	37100216	drupal_build_form( )	.../form.inc:130
5	0.3843	37100536	drupal_retrieve_form( )	.../form.inc:350
6	0.3843	37101368	feeds_tamper_ui_list_form( )	.../form.inc:841
7	0.3998	37993816	feeds_tamper_load_by_importer( )	.../feeds_tamper_ui.admin.inc:23
8	0.4142	40964624	feeds_tamper_get_plugins( )	.../feeds_tamper.inc:159
9	0.4142	40964624	ctools_get_plugins( )	.../feeds_tamper.inc:238
10	0.4143	40965432	ctools_plugin_load_includes( )	.../plugins.inc:278

On PHP 5.6.10 it's working fine.

Comments

Daniel Wentsch created an issue. See original summary.

Daniel Wentsch’s picture

Issue summary: View changes
twistor’s picture

Status: Active » Closed (duplicate)
Shiraz Dindar’s picture

thanks for timely fix.

foxesden34’s picture

Hi this is still not working with 7.50 and php7?
mod_fcgid: stderr: PHP Fatal error: Redefinition of parameter $source in /var/www/clients/client2/web7/web/dir/sites/all/modules/feeds_tamper/plugins/default_value.inc on line 36, referer: http://bbbb.co.uk/admin/structure/feeds/gbusers
root@fd:/var/www/web/dir#

kellyimagined’s picture

7.54 is not working either. In order to get the import to work, I needed to turn off feeds_tamper + feeds_tamper_ui

waverate’s picture

As indicated by twistor, patch provided at #2 of #2567431: [PHP 7 Compatibility] case: feeds_tamper_default_value_callback function.

Verified using:

  • PHP 7.1.1,
  • Drupal 7.54,
  • Feeds 7.x-2.0-beta3, and
  • Feeds Tamper 7.x-1.1 (with patch).
apermuy’s picture

Hi!

Feeds Tamper 7.x-1.1+4-dev works fine for me with:

  • Drupal core 7.54
  • PHP 7.0.18
  • Feeds Tamper 7.x-1.1+4-dev
  • Feeds 7.x-2.0-beta3

:)

Jens Peter’s picture

Status: Closed (duplicate) » Active

This is not working for me.
PHP 7.1 gives error 500.
PHP 5.6 is working perfectly.

Core (7.56) and all modules updated is updated to latest version.

andres.torres’s picture

can confirm, still present with php 7.0.22 on Ubuntu

php --version

PHP 7.0.22-0ubuntu0.16.04.1 (cli) ( NTS )
Copyright (c) 1997-2017 The PHP Group
Zend Engine v3.0.0, Copyright (c) 1998-2017 Zend Technologies
with Zend OPcache v7.0.22-0ubuntu0.16.04.1, Copyright (c) 1999-2017, by Zend Technologies
with Xdebug v2.4.0, Copyright (c) 2002-2016, by Derick Rethans

ikeigenwijs’s picture

migration to php7.1
Switching to tamper dev branche worked for us.

php --version
PHP 7.1.8-2+ubuntu16.04.1+deb.sury.org+4 (cli) (built: Aug 4 2017 13:04:12) ( NTS )
Copyright (c) 1997-2017 The PHP Group
Zend Engine v3.1.0, Copyright (c) 1998-2017 Zend Technologies
with Zend OPcache v7.1.8-2+ubuntu16.04.1+deb.sury.org+4, Copyright (c) 1999-2017, by Zend Technologies
with Xdebug v2.5.5, Copyright (c) 2002-2017, by Derick Rethans

jose-khemistry’s picture

Running PHP 7.0.15
Drupal 7.56
Feeds Tamper 7.x-1.1

Renaming the one of the parameters fixed the issue for me in this case the last parameter $source to $sourceb

function feeds_tamper_default_value_callback($source, $item_key, $element_key, &$field, $settings, $sourceb) {
kevster’s picture

As per #11 I can confirm that switching to latest dev also fixed the issue for me - many thx.

7.56
php 7.0.22
nginx

jamesrward’s picture

Status: Active » Closed (duplicate)
Related issues: +#2567431: [PHP 7 Compatibility] case: feeds_tamper_default_value_callback function

This has been solved on dev but it has not made it into the latest stable release. If you aren't using the dev branch or applying this patch you will still get this error.