The downloaded enclosures are not cleaned up once mapped, at which point they are duplicated. Patch adds a delete line after mapping.

CommentFileSizeAuthor
#4 863494-4_cleanup_temporary.patch767 bytesalex_b
feeds.deltmpfileenc.patch942 bytesekes
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

ekes’s picture

ekes CreditAttribution: ekes commented
Status: Active » Needs review
alex_b’s picture

alex_b CreditAttribution: alex_b commented
Status: Needs review » Needs work

Great catch.

Reading up on the mapper and the enclosure I see that the temporary file is not only not removed, but it is downloaded, then *copied*, then not removed.

But reading field_file_save_file() I assume there is no way to avoid copying: field_file_save_file() assumes a local filepath as input that it will copy into its final place. What's more is that not using field_file_save_file() would require significant code duplication and dangerous assumptions about its internal functionality.

Otherwise, that patch is looking good. Need to apply and run tests.

alex_b’s picture

alex_b CreditAttribution: alex_b commented
Status: Needs work » Needs review

Sorry, NR of course.

alex_b’s picture

alex_b CreditAttribution: alex_b commented
FileSize
863494-4_cleanup_temporary.patch767 bytes

The problem with deleting the file is that right after filemapper there could be another API user calling getFile() and getFile() would return a path to a file that does not exist anymore.

Please review this approach: it deletes temporary files on __destruct().

ekes’s picture

ekes CreditAttribution: ekes commented

Applied and working as expected here.

alex_b’s picture

alex_b CreditAttribution: alex_b commented
Status: Needs review » Reviewed & tested by the community

RTBC?

alex_b’s picture

alex_b CreditAttribution: alex_b commented
Title: Enclosures temporary file not deleted » Delete temporary enclosures file

Committed, thank you.

http://drupal.org/cvs?commit=399580

alex_b’s picture

alex_b CreditAttribution: alex_b commented
Status: Reviewed & tested by the community » Fixed

Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for 2 weeks with no activity.

alex_b’s picture

alex_b CreditAttribution: alex_b commented

This patch does not interact well with #755556: Support saving local files in filefields. We will need to remove it at least as a temporary measure. See #919172: Fix enclosure source files deleted.