FileFetcher Attached to Feed Node, Upload Field Not Saving File Path

=Short Description=

When using a FileFetcher attached to a feed node to upload a file, the resulting filepath of the uploaded file does not get saved. This means that the file's content never gets loaded into 'batch->raw', and the filepath does not 'stick' for subsequent node edits.

= Environment Info =
Feeds Dev (downloaded from CVS on 2010-03-12)
Acquia Drupal 6.15
MySql 14.14, distrib 5.137

=Longer Description=
FileFetcher does not seem to work when it is part of an importer that is attached to a feed node.

This is repeatable. Here is how to see it for yourself:

1. Override the default 'Feed' importer to use 'File Upload' for the fetcher.
2. Save an RSS feed to a file (see the attached 'topstories' file for an example)
3. Create a Feed node and use the 'upload' field to upload the saved RSS file
4. Save the node.
5. Try to do an import on the node. No feed content will be found.
6. Try to edit the node. The Feed 'file' fields will be blank.

= Diagnosis =
It looks like the file is being uploaded successfully, but that the path is not being saved as the 'feed source'. It looks like we are trying to save the path in feeds_nodeapi function for 'validation' operations, but that this save is unsuccessful.

I had used the development module's debugging 'dvm' statements to trace file uploading. The file does get successfully uploaded into the '*/files/feeds/' directory. But the path to this file does not get saved.

On line 83 of FeedsFileFetcher.inc in the sourceFormValidate function, it looks like we are trying to save the path to the Feed subform's 'source' field

// If there is a file uploaded, save it, otherwise validate input on                                             
    // file.                                                                                                         
    if ($file = file_save_upload('feeds', array(), $feed_dir)) {
      file_set_status($file, FILE_STATUS_PERMANENT);
      $values['source'] = $file->filepath;
    }

The sourceFormValidate function gets called via 'configFormValidate' on line 277 of feeds.module, in the feeds_nodeapi function, for the 'validate' operation. It looks like the feeds_nodeapi function tries to update the '$node' object with form values. Within the 'validate' operation code block the node object does get updated (e.g. $node->feeds->source has the file path). But the node object data seems to get lost when the 'update' operation code block comes around (e.g. $node->feeds->source is blank).

I'm not sure what is causing this. Perhaps node form values can not be modified in validate functions?