Early Bird Registration for DrupalCon Portland 2024 is open! Register by 23:59 PST on 31 March 2024, to get $100 off your ticket.
Port emvideo, emimage mappers from Feed Element Mapper.
Port tests for it.
Document it.
AlexUA has done some preliminary work on this. To make emfield mapping fully functional, we may need to add a media parser.
Comment | File | Size | Author |
---|---|---|---|
#90 | 623432-90_emfield.patch | 5.73 KB | alex_b |
#77 | 623432_emfield_test.patch | 6.55 KB | cglusky |
#78 | 623432_emfield_mapper_test.patch | 5.51 KB | cglusky |
#74 | Screen shot 2010-07-20 at 4.56.08 PM.png | 74.88 KB | cglusky |
#64 | emfield.inc_.txt | 1.7 KB | Alauddin |
Comments
Comment #1
alex_b CreditAttribution: alex_b commentedAs an example for the API, take a look at mappers/content.inc should be used. For documenting the Mapping API, I opened an issue #623466: Document mapping API.
Comment #2
regmanabq CreditAttribution: regmanabq commentedI wish i knew more about writing drupal modules and emfield. I'd jump in and help, I really love Feeds but need emfield in the worst way.
First volunteer to help test once we get something to alpha.
Comment #3
sarasioux CreditAttribution: sarasioux commentedI spent a little time working on this over the weekend and ran into some difficulties, hoping someone can help. I'm trying to import a feed of products from Zazzle (http://zazzle.com/melodev/rss), and grab the Media enclosure and stick it into an Emfield so I can present different sizes of the image inside Drupal.
Borrowing from mappers/content.inc was very easy, and I had a new target & mapping setup in no time at all. Unfortunately, once my callback was actually executed, I could not find a way to get at the Media information from the value that was provided to me.
Here's what I did:
This function successfully exposes Emimage fields to the mapper on the Feeds configuration page. I chose to map "Enclosures" to my "Emimage" field.
And then a very simple:
Unfortunately no matter what I do I cannot get any information to come through on "$value". If I exit out of the SimplePie parser and print_r on the $feed it's returning, the "enclosures" value is quite happily filled with all sorts of great information about the media file.
So my question is, how do I get that enclosures array from my parser to successfully arrive in my set target function?
Thanks in advance for any insights anyone can provide. I was a big fan of FeedAPI + Mapper so I'm looking forward to Feeds. I am doing my own forced inheritance on it for now, but getting access to media fields would be a huge plus.
Comment #4
alex_b CreditAttribution: alex_b commentedDon't you have to map the URL of the item to the emfield and not the enclosure? There are no enclosures on the feed you're using.
This is calling for a good description of the mapping target :)
Comment #5
sarasioux CreditAttribution: sarasioux commentedWell to be honest I expected something like "Media" to show up in the "Select a source" box, but Enclosures is the closest thing to what I was expecting. You mentioned in the description of this ticket that "we may need to add a media parser"? If that is something I can dive into let me know, I'm not sure where to start in parsing out Media so it appears in the "Select a source".
And if I'm 100% off on my interpretations here please point me in the right direction! Attaching a screenshot of my available sources based on the feed above.
Comment #6
alex_b CreditAttribution: alex_b commentedPlease let me know: Does Item URL not work?
To my knowledge item URL is the input that emvideo/emimage is looking for. If this is the case, we need to add a better legend to the emfield/emvideo targets.
The media parser *might* be necessary for retrieving meta information about media. E. g. blip.tv and youtube.com feeds include namespaced meta information on the media they're carrying. I haven't thought about this more than that.
Comment #7
sarasioux CreditAttribution: sarasioux commentedWell that sounded promising, but "Item URL" is actually the URL to the Feed Item itself, not the URL to the Media file attached to the Feed Item.
$value contained this:
But I want it to contain this:
Comment #8
Alex UA CreditAttribution: Alex UA commentedI'm pretty sure I see what the problem is, though I haven't had a lot of time to spend on figuring out what the cause is, which is that it is inserting the item url value into the wrong part of the emfield field array. It should be getting inserted into $field_MyFieldName[0]['embed'], but it is getting inserted into $field_MyFieldName[0]['embed']['value']. That's why you get the following two strange behaviors:
1- if you edit a post you'll note that the embed string isn't in the field, yet there's a link to it below the field.
2- the link to that field doesn't actually go anyplace (because it's expecting the value, not the embed).
Emfield takes the embed string, parses it, and then it creates the value (i.e. the video, image, or audio id) as well as the accompanying $data array, that stores all of the info emfield needs.
Anyway, hope this helps...
Comment #9
mcaudy CreditAttribution: mcaudy commentedSubscribing.
Comment #10
Alex UA CreditAttribution: Alex UA commentedAttached is a simple provider that I was using to test. I changed both mentions of 'value' to 'embed', but it's still putting the url into the wrong place.
Comment #11
Alex UA CreditAttribution: Alex UA commentedOops, fixed some mistakes in the last one...
Comment #12
Alex UA CreditAttribution: Alex UA commentedAnd we have a winner! I removed and readded the mapping on the feeds mapper page and this is now working as expected. W00t!
Comment #13
regmanabq CreditAttribution: regmanabq commentedWoot!!! One down!!!!
Comment #14
alex_b CreditAttribution: alex_b commentedAwesome. Thanks Alex UA.
- added CVS $Id$ string
- made sure comments aren't spilling the 80 character column
- rolled an actual patch
Mapper is RTBC.
The only thing missing now is a test (can be ported from FeedAPI Mapper, too).
Comment #15
sarasioux CreditAttribution: sarasioux commentedOkay, first of all this patch requires "emvideo". Applying the patch gave this error immediately:
Fatal error: Call to undefined function emvideo_field() in sites/all/modules/feeds/mappers/emfield.inc on line 57
I'm not using emvideo, I'm using emimage, and the feeds module should use the appropriate function for the field that was mapped to.
Secondly, I think this patch is trying to solve the problem of mapping a value into an emimage field, when the actual problem I'm having is that there is no value being parsed out of the field in order for me to map.
I'm going to hack up the parser and make it work for myself and then share how I did it so you guys can tell me how to do it better. :)
Comment #16
sarasioux CreditAttribution: sarasioux commentedIt seems like simplepie.inc get_real_type() does not support image formats. This seems to be why I can't get images out of my enclosures.
The data I need is in $item->raw, so I did the following.
On line 79 in FeedsProcessor.inc I changed the following line:
So that a custom callback written by a user is also passed the entire original source item so they can futz with it.
From there I was able to pull the values I wanted out of enclosures and write a completely custom target mapper.
Still struggling with saving emimage cck data appropriately but that is at least a normal problem I can tackle. I believe that passing the full original source item to custom target mappings is a great way to give people more customization in the Feeds module -- please let me know if this completely breaks some standards or something.
Finally, the emfield patch above needs some attention. It is calling variables $items and $field_name that were never declared, it only supports videos, etc.
Comment #17
Alex UA CreditAttribution: Alex UA commentedSarah-
I think you're getting a little mixed up here. Feeds should only grab the original url and then emimage should take care of the rest. I would start by just changing out "emvideo_field" with "emimage_field" and see if that gets emfield to work correctly (you'll note a populated emfield data array once you are). Once that is working you can select the image (or whatever else is attached to the returned XML) you want from emfield's data array (which is the appropriate place for this to happen).
Comment #18
sarasioux CreditAttribution: sarasioux commentedAlex,
In your function emfield_feeds_set_target($node, $target, $value), $value is always empty when I choose "enclosures". If I choose "Item URL" as suggested above, $value is populated with the URL to the product node, and *not* the URL to the product image that is provided in enclosures.
Changing emvideo to emimage makes no difference if the $value parameter is empty.
I've tried mapping every available source to an emfield and just echoing $value & exiting --- *none* of the available sources contain any information about media files.
For now I have solved the problem for myself, but the fact is that simplepie.inc does not appear to support image files in enclosures.
Sara
Comment #19
Alex UA CreditAttribution: Alex UA commentedSara-
After re-reading this thread I think you're using emfield in a fundamentally different way than the norm. Usually, users of emfield post the url or embed code for a piece of media, for example:
That code is parsed, and a request is sent to the provider (YouTube in this example). Emfield then retrieve all of the information available for that video/audio/image file, and (via the provider file) it is then compiled it into the emfield data array, which is used to give you things like thumbnails, width, height, etc.
In this case you are not using a provider file, so while emfield does sort of support you posting images from zazzle via the custom_url provider, it's not meant to grab anything automatically (i.e. you have to paste in the actual path to the image), which is why it isn't populating any of the other info.
Comment #20
sarasioux CreditAttribution: sarasioux commentedI honestly don't care whether I use emfield or a plain CCK text field to store the image URL. I am having no problems with emfield. I am only having problems with retrieving the URL to an image out of an enclosures array in a feed item.
I will spend some time this weekend writing my Simplepie enclosures parsing findings up for you so maybe it will help. Like I said, when simplepie.inc is parsing through the enclosures array, it runs get_real_type() on every item it finds to try and identify the mime type for the file.
In simplepie.inc between lines 7171 and 7176, there is no support for an image mime type.
Perhaps this means that Zazzle's RSS format is non-standard and Simplepie does not know how to deal with image files that show up in the enclosures array.
Comment #21
Alex UA CreditAttribution: Alex UA commentedSara-
I understand your frustration, but this thread is about porting the mappers for emfield, not about helping you figure out how to post images in general using feeds, nor about zazzle's rss format. Please start a separate support request for either of those topics instead of continuing to push this thread off topic.
Thanks
Comment #22
rjkuyvenhoven CreditAttribution: rjkuyvenhoven commentedthis code generates the following errors when populating the fields:
Invalid argument supplied for foreach() in /sites/all/modules/emfield/contrib/emvideo/emvideo.module on line 275.
Invalid argument supplied for foreach() in /sites/all/modules/emfield/emfield.cck.inc on line 65.
these errors are resolved by initializing the $items variable as an array in the emfield_feeds_set_target function
Comment #23
sarasioux CreditAttribution: sarasioux commentedThanks for your support Alex. Please let me know if I can help with any additional testing in the future.
If someone else gets this new Feeds module to work with mapping to an emimage field (not emvideo) please contact me directly so I can pick your brain about how you had to set it up.
Thanks!
Comment #24
Alex UA CreditAttribution: Alex UA commentedAs you mentioned, you aren't trying to use emfield at all, so emimage won't be able to help you (and thus you aren't really testing this mapper, or emfield itself).
I think this is probably more along the lines of what you're looking for:
http://drupal.org/project/feeds_imagegrabber
Comment #25
fender-dupe CreditAttribution: fender-dupe commentedI would like to embed youtube videos for example
http://gdata.youtube.com/feeds/base/users/youtube/uploads
Right now on my site only image is embedded and in the mapper I can see only the following options
Title Title
Description Body
Published date Published date
Item URL (link) URL
Item GUID GUID
Categories Taxonomy: Categories
there is no embed field to map???
Comment #26
fender-dupe CreditAttribution: fender-dupe commentedhere is the screeshot
Comment #27
rjkuyvenhoven CreditAttribution: rjkuyvenhoven commenteduse Item URL (link)
Comment #28
fender-dupe CreditAttribution: fender-dupe commentedwell i am using it and still get only the picture of the video, not in fact an embedded video on my site
Comment #29
BenK CreditAttribution: BenK commentedSubscribing....
Comment #30
strr CreditAttribution: strr commentedIs there now a sollution to map the importer to a custom cck field like emfield smewhere?
Comment #31
strr CreditAttribution: strr commentedI creatd 3 Fields in CCK (Author, Emfield, Source)
none of them are displayed in the "target dropdown" on the mapping edit page for any of the Imprters.
Do i miss something. Ithink feeds is not suppoting cck custom fields at all ? Do i miss something?
Comment #32
dixon_Here is a slightly changed patch from #14. What I've done is to remove the call to
emvideo_field()
inemfield_feeds_set_target()
. That call isn't necessary as CCK will handle that by it self.Everything works as expected for me, with this patch.
Comment #33
aaron CreditAttribution: aaron commentedsubscribe
Comment #34
fender-dupe CreditAttribution: fender-dupe commentedWHY NOBODY HELPS HERE
i maean there are newbies here that need help and you just ignore them, we dont even know how to apply a patch for god sake
Comment #35
Scott J CreditAttribution: Scott J commentedFender,
This is code in development. It is not meant to be used by 'newbies'. Have you tried using the feedAPI module http://drupal.org/project/feedapi , which is more mature? Come back to this module after it is past 'alpha', or preferably 'beta'.
In answer to your question, I found these instructions: http://drupal.org/patch/apply . I don't think that I am any the wiser after reading this, but if you understand it, go to it.
Scott Jackson
Comment #36
fender-dupe CreditAttribution: fender-dupe commentedSo why you suggest anybody should switch from feedapi to feeds if it is not proper time, i never tried feed api
Comment #37
robertDouglass CreditAttribution: robertDouglass commentedThe patch works for me with latest from HEAD. The file that the patch creates has to go into /mappers. The "Item URL (link)" field then maps to the emfield for video. Didn't test images. I'm not familiar enough with the architecture to mark RTBC, but am glad to have the patch since this is one of the prime uses of feed_api that I can now replace.
Comment #38
fender-dupe CreditAttribution: fender-dupe commentedi am really confused here, isnt it enough to add the file called emfield.inc and copy the content of the patch inseide feeds/mappers?
Or is the process much more complex?
Please help newbise, at least somebody should fix this to support the youtube and vimeo at least, now the plugin is useless
I have added that new file and I get this error
Parse error: syntax error, unexpected T_FUNCTION in /home3/altermed/public_html/modules/feeds/mappers/emfield.inc on line 22
Comment #39
robertDouglass CreditAttribution: robertDouglass commented@fender, if you mean do you copy the file http://drupal.org/files/issues/623432-32_emfield_mapper.patch into feeds/mappers, no, that's not it. Actually it's the first step, but then you have to go in there on the command line and type:
patch < 623432-32_emfield_mapper.patch
Or alternatively, use some other program that can translate patches.
Comment #40
fender-dupe CreditAttribution: fender-dupe commentedwhere is the command line, is it in mysql?
Why nobody repairs or updates the whole plugin, please we need it, now my site is amess, at least fix youtube or vimeo
Comment #41
robertDouglass CreditAttribution: robertDouglass commented@fender - the nature of things here is that you have to use tools like google to answer basic questions like "what is the command line", and you have to stop pestering developers to do their job faster.
Comment #42
aaron CreditAttribution: aaron commentedthis thing is so ready. works like a charm! (just set it up on the new dojo, and i nearly cried because it was so easy...)
the code is clean & simple as well. perfect!
Comment #43
fender-dupe CreditAttribution: fender-dupe commentedok i am learning to patch right now, not easy, but I'll be bak :)
Comment #44
aaron CreditAttribution: aaron commented@fender: http://drupal.org/patch/apply is where you should start (edit: sorry, @swj, didn't see that you posted that earlier...)
Comment #45
alex_b CreditAttribution: alex_b commentedGreat - we're getting there.
2 things are missing still:
- Tests
- Better instructions
The inline description says "The Embedded !name field of the node" - could this be clearer? I. e. shouldn't it say something to the effect of: "Map a URL of a page containing media to this field." ?
Comment #46
aaron CreditAttribution: aaron commented"Map a URL of a page containing media to this field." might be technically correct, but possibly still confusing to the end user, since the end effect is not the URL but the embedded media itself.
Perhaps something like "Map a URL of a page to embed its media to this field."
Or like @alex_b wrote in irc but I almost missed: "The Embedded !name field of the node. Map a URL of a page containing media to this field." That might even be better.
Comment #47
alex_b CreditAttribution: alex_b commented#46:
"The Embedded !name field of the node. Map a URL of a page containing media to this field."
Let's use this line then. I summarize:
What's missing is:
1) Write tests.
2) Change existing description of target to "The Embedded !name field of the node. Map a URL of a page containing media to this field."
Comment #48
Erik Seifert CreditAttribution: Erik Seifert commentedHas something changed ?
Because i need to urldecode $value before everything works correct
Comment #49
sagannotcarl CreditAttribution: sagannotcarl commentedThat patch in #32 worked great for me.
Comment #50
awjrichards CreditAttribution: awjrichards commentedPatch 32 is working fine for me with Flickr photo links. Great work - thanks! I will test later with YouTube videos.
Comment #51
awjrichards CreditAttribution: awjrichards commentedSeems to be working just fine with YouTube videos as well. Thanks again!
Comment #52
alex_b CreditAttribution: alex_b commentedAny of the happy users up for locking down this patch by writing tests and adjusting UI per #47? :-)
Comment #53
sagannotcarl CreditAttribution: sagannotcarl commentedHere's a patch with the description changed. I'm afraid I can't be too helpful with the test though.
Comment #54
pvhee CreditAttribution: pvhee commentedSubscribing
Comment #55
pvhee CreditAttribution: pvhee commentedI added a unit test to #53 that includes a CSV with two video fields. The import works nicely.
However, as here I have the same problem that $this->assertCCKFieldValue('video', 'http://www.youtube.com/watch?v=gpkhANg919Y'); doesn't work, while values are correctly inserted in the database.
Patch contains #53 + unit test + sample csv file.
FYI, test files here:
Comment #56
cglusky CreditAttribution: cglusky commentedGreat work folks! Patch in #53 applied cleanly. It's working fine to import from Flickr Atom Feed with the latest required modules (I am running almost all dev versions on my test site) on drupal 6.16. I am using Common Syndication Parser. I have not tested it with anything else.
Sorry, no help with the unit test issue in #55 (which is why I patched with #53).
Comment #57
AntiNSA CreditAttribution: AntiNSA commentedI have tried the patch and am unable to get it to show images whic are embedded in the feed in emfield_image.... I used this patch and created the inc file which I put into the mapper directory and can see the mappings for the enclosure to the emfield.
I meant to say I tried patch # 53
Comment #58
Remon CreditAttribution: Remon commented+1
Comment #59
srobert72 CreditAttribution: srobert72 commentedSubscribing
Comment #60
alex_b CreditAttribution: alex_b commented#55: awesome.
Use $this->show() or $this->show('node/[nid]/edit') to figure out what the UI displays. show() will create a warning that prints the test site's current screen or the screen of the path you specified to the test log.
Comment #61
ccoppen CreditAttribution: ccoppen commentedThis doesn't seem to work with EMField 6.x-2.x-dev
Comment #62
ccoppen CreditAttribution: ccoppen commentedI take that back. It works fine with emfield 6.x-2.x-dev.
I had some issues with the underlying folder structure.
Comment #63
Remon CreditAttribution: Remon commentedworks as promised :) thanks
Comment #64
Alauddin CreditAttribution: Alauddin commentedHope this helps those that are new and are looking for a quick setup.
obviously you need to have the following modules
1) feeds
2) emfield
add a cck field type (embed video) to content type > feed item, as this is what the feed mapper is updating by default.
Now, lets just apply the patch / modify the feeds module to work with emfield
I have taken the patch form # 53 and converted it to emfield.inc
Now all you have to do is place the attached file in the folder below and then remove the .txt
\sites\all\modules\feeds\mappers
so in the end you have \mappers\emfield.inc
Thats it.
now you can see the cck fields for mapping under the target section.
Just remove the old source Item URL (link) and add a new to map to your cck embed video field.
Comment #65
AntiNSA CreditAttribution: AntiNSA commentedawesome! Will try now!
Comment #66
AntiNSA CreditAttribution: AntiNSA commentedSo would the best strategy be to create a custom field for
1) embedded video
2)embedded audio
3)embedded image
and then we can create a
map enclosure--->embedded video field
map enclosure--->embedded audio field
map inclosure---->embedded video field
and teh mapped wnclosure , even though there is only one option, will know the difference and chose the right one of the three custom fields you created to map too?
Comment #67
locomo CreditAttribution: locomo commented#55 worked for me
Comment #68
EvanDonovan CreditAttribution: EvanDonovan commented#55 worked for me as well. I did not test the test, however. What more, if anything, is necessary before this can be set to RTBC?
Comment #69
Alex UA CreditAttribution: Alex UA commentedMoving back to RTBC- this thing is ready for prime time!
Comment #70
alex_b CreditAttribution: alex_b commentedI hate to be harping on this, but we do need tests to commit the mapper to Feeds. Tests can be pillaged from FeedAPI mapper's emfield mappers.
Comment #71
PMorris CreditAttribution: PMorris commentedAnyone able to get this working with audio too? I'm trying to import podcasts with emaudio fields but I couldn't get them to show up. Video works fine though.
Comment #72
XiaN Vizjereij CreditAttribution: XiaN Vizjereij commentedSeems to be broken with the newest emvideo 1.23.
Can anyone confirm this?
Edit : Yes its def. not working for emvideo 1.23. It works fine with 1.20.
Comment #73
peterjlord CreditAttribution: peterjlord commentedYes for me to from a fresh install had to downgrade emvideo to 1.20 to get videos import
Comment #74
cglusky CreditAttribution: cglusky commented#72 & #73 according to emfield project page there was an error in the 1.21-23 releases. Please try 1.24 and see if that helps.
@alex_b & @pvhee I have used the patch in #55 and get the same results with the SimpleTests as mentioned in #55. So I ran show() as alex suggested and it all seems to be working. scrnsht attached. I also reviewed the code in the patch and can not see anything I would change. The test is cut/paste from feeds.content tests. Is assertCCKFieldValue a viable option for non-native CCK field types/widgets? Re #70 I had a look at FeedAPI mappers tests and they do not seem to be too complete.
Comment #75
Ari Gold CreditAttribution: Ari Gold commentedI've followed instructions in #64 to no avail.
I tried attaching the importer to "Feed" and "Feed item" and added cck embed video field to both content types.
I don't get the new cck embed video field as an option when trying to map source to target.
I also was using emfield 1.24 and downgraded to 1.20...
Any suggestions?
Comment #76
peterjlord CreditAttribution: peterjlord commentedThanks for that. I've upgraded to 1.24 and all seems to be working OK
Comment #77
cglusky CreditAttribution: cglusky commentedEDIT: DISREGARD THIS PATCH. It's not right at all. Will fix now.
Comment #78
cglusky CreditAttribution: cglusky commentedThis patch should be complete. I do not use CVS so it's diff'd from the sites/all/modules root. You will need to apply it from there.
Comment #79
Fortyhands CreditAttribution: Fortyhands commentedI used emfield (current, working version) with feeds (the last patch provided by cglusky) to create feed item nodes from youtube RSS - videos showed up perfectly. Thanks a ton for all of your hard work!
Comment #80
alex_b CreditAttribution: alex_b commentedNeeds tests for getting committed. Can be modeled after some of the existing mapper tests.
Comment #81
cglusky CreditAttribution: cglusky commented@alex_b the patch in #78 has tests
Comment #82
mariano.barcia CreditAttribution: mariano.barcia commentedsubscribing
Comment #83
alex_b CreditAttribution: alex_b commentedcglusky: sorry, overlooked that. Will review as soon as I get some air.
Comment #84
paulap CreditAttribution: paulap commentedHi!
I'am new to feeds.
Is there any planning to deliver this mapper as a module?
How can I help to test? I have only a hosted drupal installation without possibilities to run patch scripts.
Comment #85
alex_b CreditAttribution: alex_b commentedpaulap: I'd actually like to get this into beta5, need to review still.
Comment #86
mandclu CreditAttribution: mandclu commentedSubscribing. This used to work really well in Feed API, I'd really rather not have to revert back to that just to get video import working.
Comment #87
torgosPizzaTested this patch against latest Feeds stable, works like a charm for grabbing YouTube videos (as well as their thumbnails, titles descriptions, and even thumbnails and other YouTube data). Thanks for your work in getting this patched!
Comment #88
srobert72 CreditAttribution: srobert72 commentedI use patch #78 since it has been released. And I'm satisfied with it.
I map Flickr pictures into emfield image field.
patch #78 on Feeds release : 6.x-1.x-dev (2010-Jul-29)
Comment #89
mstrelan CreditAttribution: mstrelan commentedsubscribe
Comment #90
alex_b CreditAttribution: alex_b commentedTests were broken, fixed. This is RTBC now.
Comment #91
alex_b CreditAttribution: alex_b commentedThis is committed now, thank you.
http://drupal.org/cvs?commit=423262
Comment #92
AntiNSA CreditAttribution: AntiNSA commentedIm having a problem, can you give me the csv file? its not in the newest patch, tthanks
Comment #93
AntiNSA CreditAttribution: AntiNSA commentedits ok I got it
Comment #94
AntiNSA CreditAttribution: AntiNSA commentedso, If you want to map an enclosure to em audio, em video, and additionally to filefield, because youiu cant know ahead of time which type of media is in the enclosure, and you want to be ready for all types of media , using simplepie, do you just have multiple enclosure mappings? I have tried this and get so many errors/unable to import when I map the Enclosure to more than one target .
Comment #95
alex_b CreditAttribution: alex_b commentedFYI:
http://drupal.org/cvs?commit=425688
http://drupal.org/cvs?commit=425678
The latter kept enclosures from working.
Comment #96
AntiNSA CreditAttribution: AntiNSA commentedYhanks so much! Applying patches now..