Error using feeds 8.x-3.x on Drupal Core 8.2 [#2908959]

Error during import using feeds 8.x-3.x on Drupal core 8.2

Fatal error:  Call to undefined method Drupal\Core\Entity\ContentEntityType::entityClassImplements() in /var/www/html/scca/app/modules/contrib/feeds/src/Feeds/Target/EntityReference.php on line 89

I created a patch file for, and should in the future maybe should have a release candidate tag to simplify the instal of it.

Comment	File	Size	Author
#2	entityClassImplements_patch_for_8.2_core.patch	742 bytes	aluzzardi
#2
	entityClassImplements_patch_for_8.2_core.patch	830 bytes	aluzzardi

Support from Acquia helps fund testing for Drupal Acquia logo

Comments

Comment #1

14 September 2017 at 21:22

aluzzardi created an issue. See original summary.

Comment #2

aluzzardi

Pelotas, RS

CreditAttribution: aluzzardi as a volunteer commented 14 September 2017 at 21:27

File	Size
entityClassImplements_patch_for_8.2_core.patch	742 bytes

1 file was hidden/shown/deleted

File	Size
entityClassImplements_patch_for_8.2_core.patch	830 bytes

Comment #3

MegaChriz CreditAttribution: MegaChriz as a volunteer commented 14 September 2017 at 21:37

Status:

Active

» Closed (duplicate)

This has been reported before in #2897213: Mark latest version as requiring core 8.3+, so closing this as a duplicate.

I'm not so sure if older versions of core should remain to be supported. Should they?

Comment #4

aluzzardi

Pelotas, RS

CreditAttribution: aluzzardi as a volunteer commented 14 September 2017 at 21:51

hi @MegaChriz

No, this is different, I'm making a patch to make the feeds work with the version 8.2 of the core.
Hi makes a patch to force the feeds to only work with the version 8.3 or higher.
Pleas check both.

Comment #5

MegaChriz CreditAttribution: MegaChriz as a volunteer commented 14 September 2017 at 21:59

But it is originating from the same issue: error on 8.2.
There are just two ways to fix it: either adding a deprecated method back and keep supporting 8.2 or explicitly remove 8.2 support.

Comment #6

aluzzardi

Pelotas, RS

CreditAttribution: aluzzardi as a volunteer commented 15 September 2017 at 10:58

So basically you decide to explicitly remove the support to 8.2?
Well, at least the patch is arelady here if you anyone needs to use it.

Comment #7

MegaChriz CreditAttribution: MegaChriz as a volunteer commented 15 September 2017 at 11:52

I have not decided yet, though I'm more leaning towards to remove 8.2 support because 8.2 is officially no longer supported and because in order to support 8.2 we have to use deprecated code.

Comment #8

MegaChriz CreditAttribution: MegaChriz as a volunteer commented 15 September 2017 at 12:20

Okay, I have asked someone from the Drupal core team and the advice for module maintainers is to officially only support the latest stable Drupal core release. I think it makes sense to do that. This way we are free to use the latest API's during development.

People that cannot upgrade to 8.3 yet, can then indeed use your patch. So thanks for posting!