Right now the methods FeedsSource::import() and FeedsSource::pushImport() both perform the same tasks when the import task is done, with the exception that FeedsSource::pushImport() doesn't invoke the rules event 'feeds_after_import' (which I think it should do).

Let's combine these tasks that need to be done at the end of an import into one method: FeedsSource::finishImport().

This is inspired by the D8 version of Feeds where the \Drupal\feeds\Entity\Feed class (equivalent of FeedsSource in D7) also has a method with the same name.

Patch will follow.

Support from Acquia helps fund testing for Drupal Acquia logo

Comments

MegaChriz created an issue. See original summary.

MegaChriz’s picture

Status: Active » Needs review
FileSize
2.3 KB

  • MegaChriz committed 5b2113f on 7.x-2.x
    Issue #2867182 by MegaChriz: Added a finishImport() method to...
MegaChriz’s picture

Status: Needs review » Fixed

Committed #2.

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.