Hello

I've found that each time when I want to add new feed, like with this url /feed/add/MY_FEED
I should fill the form. There is field for title, and I think that it can be pretty uncomfortable to type there something valuable each time.

form

CommentFileSizeAuthor
#2 feeds-name-for-new-feed-2651326-2-D8.patch868 byteseugene.ilyin
#2 screenshot_243.png33.37 KBeugene.ilyin
screenshot_242.png32.32 KBeugene.ilyin
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

eugene.ilyin created an issue. See original summary.

eugene.ilyin’s picture

eugene.ilyin CreditAttribution: eugene.ilyin as a volunteer and at DrupalJedi commented
Status: Active » Needs review
FileSize
screenshot_243.png33.37 KB
feeds-name-for-new-feed-2651326-2-D8.patch868 bytes

I propose to fill this field automatically with machine name of the feed and current date + current time.

But in any case, if user wants his own name, it can change it easy.

filled title

Status: Needs review » Needs work

The last submitted patch, 2: feeds-name-for-new-feed-2651326-2-D8.patch, failed testing.

MegaChriz’s picture

MegaChriz CreditAttribution: MegaChriz as a volunteer commented
Status: Needs work » Needs review

Only known test failures, so setting status back to "Needs review".

I'm not yet sure about autofilling the title with a default value. Maybe there should be a setting instead for requiring a title? Have to take a closer look.

eugene.ilyin’s picture

eugene.ilyin CreditAttribution: eugene.ilyin as a volunteer and at DrupalJedi commented

Maybe we should add additional option to enable this functionality, but actually I don't think so. I'm waiting for your opinion.

MegaChriz’s picture

MegaChriz CreditAttribution: MegaChriz as a volunteer commented

In the D7 version of Feeds, the title of a "feed node" is set to non-required because some parsers (like the common syndication parser) can automatically provide a title from the source. Maybe the title shouldn't be required when the parser can set the title? Or maybe Feeds should set a default title when the user leaves it empty?

eugene.ilyin’s picture

eugene.ilyin CreditAttribution: eugene.ilyin as a volunteer and at DrupalJedi commented

In the D7 version of Feeds, the title of a "feed node" is set to non-required because some parsers (like the common syndication parser) can automatically provide a title from the source. Maybe the title shouldn't be required when the parser can set the title?

Seems in D8 "feed nodes" for all kinds of feeds requires title.

Or maybe Feeds should set a default title when the user leaves it empty?

This looks better for me, but it can be not obvious that title was empty and after submitting it was filled.

Actually it depends of opinion and my option looks better for me. Because it's more obvious and it looks like a classic way - something predefined, but you can change it easily.

twistor’s picture

twistor CreditAttribution: twistor as a volunteer commented
Assigned: Unassigned » twistor
Status: Needs review » Postponed

This should be supported for parsers that can set a title, but there's no way to detect a title from a CSV file.

For CSV files, it should be possible to use a module like https://www.drupal.org/project/auto_entitylabel to automatically set the title.

Setting it to the Feed type and + the date will not be the default.

eugene.ilyin’s picture

eugene.ilyin CreditAttribution: eugene.ilyin as a volunteer and at DrupalJedi commented

@twistor

For CSV files, it should be possible to use a module like https://www.drupal.org/project/auto_entitylabel to automatically set the title.

Good idea, but not ported yet :(

Setting it to the Feed type and + the date will not be the default.

Sorry, It's not clear for me. Do you think that this opportunity would be good for CSV parser but with some configuration, or it's wrong way, and there is no sense to apply efforts to implement it?