So this is pretty silly, but Microsoft (Live) is presenting users with iCal URLs formed as "webcals://URL". That's right - webcals, because apparently they can't follow the crowd. Basically need to extend the support from #723548: Provide better URL validation and error reporting for invalid feed URLs

CommentFileSizeAuthor
#6 interdiff-4-6.txt824 bytesmglaman
#6 support_webcals_scheme-2451111-6.patch2.5 KBmglaman
#4 support_microsoft_ical-2451111-4.patch2.77 KBmglaman
#1 support_microsoft_ical-2451111-1.patch618 bytesmglaman
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

mglaman’s picture

mglaman
Primary language English
Location WI, USA
CreditAttribution: mglaman commented
Status: Active » Needs review
FileSize
support_microsoft_ical-2451111-1.patch618 bytes

Patch! Now turns webcals:// to http://

twistor’s picture

twistor CreditAttribution: twistor commented
Status: Needs review » Needs work
Issue tags: +Needs tests

This would need feeds_valid_url() to be updated.
Needs a simple test.

Are you sure that webcals isn't supposed to map to https?

mglaman’s picture

mglaman
Primary language English
Location WI, USA
CreditAttribution: mglaman at Gaggle.net, Inc. commented

You're right: https://bugzilla.mozilla.org/show_bug.cgi?id=429061

I'll update patch.

mglaman’s picture

mglaman
Primary language English
Location WI, USA
CreditAttribution: mglaman at Gaggle.net, Inc. commented
Title: Support Microsoft iCal links » Support webcals scheme for HTTPS.
Status: Needs work » Needs review
FileSize
support_microsoft_ical-2451111-4.patch2.77 KB

Updated patch and added webcals to protocol tests. Changing title, too.

Status: Needs review » Needs work

The last submitted patch, 4: support_microsoft_ical-2451111-4.patch, failed testing.

mglaman’s picture

mglaman
Primary language English
Location WI, USA
CreditAttribution: mglaman at Gaggle.net, Inc. commented
Status: Needs work » Needs review
FileSize
support_webcals_scheme-2451111-6.patch2.5 KB
interdiff-4-6.txt824 bytes

I don't know if the testbot can access itself via HTTPS, so removing that bit from testOddFeedSchemes, since testFeedsValidURL covers webcals for validation.