Support for Drupal 7 is ending on 5 January 2025—it’s time to migrate to Drupal 10! Learn about the many benefits of Drupal 10 and find migration tools in our resource center.Problem/Motivation
The following tests are not executed by the testbot:
- Common Syndication Parser (CommonSyndicationParserTestCase)
- Mapper: Date, multi value fields (FeedsMapperDateMultipleTestCase)
- Mapper: Date (FeedsMapperDateTestCase)
- Mapper: Link (FeedsMapperLinkTestCase)
- Sitemap parser (FeedsSitemapParserTestCase)
- Syndication parsers (FeedsSyndicationParserTestCase)
I suspect they were left out because most of these tests require additional dependencies and the testbot wasn't able to handle that in the past.
I'd like to have the testbot executing all tests. Right now I'm extending the tests for (among more) the mappers "date" and "link" in #1107522: Framework for expected behavior when importing empty/blank values + text field fix and I'd like the testbot to test these additional tests.
Proposed resolution
- List all test files in the feeds.info file.
- Add test_dependencies[] for modules required by the tests.
Unfortunelately, the testbot will not execute the missing tests that have extra dependencies until after commit, because - if I'm not wrong - it will not load these dependencies from a patch.
Remaining tasks
See the proposed resolution.
User interface changes
-
API changes
-
Patch will follow.
| Comment | File | Size | Author |
|---|---|---|---|
| #1 | feeds-testbot-missing-tests-2415283-1.patch | 7.5 KB | MegaChriz |
Comments
Comment #1
MegaChriz CreditAttribution: MegaChriz commentedThe attached patch add the missing test files to feeds.info and adds test_dependencies[] to feeds_test.info. Additionally it also fixes the tests Sitemap parser (which was still partly in D6 style) and Syndication parsers (which missed a download of SimplePie).
Comment #3
twistor CreditAttribution: twistor commentedI didn't verify that all dependencies were added, but this looks good.
Nice find! ouch.