Support for Drupal 7 is ending on 5 January 2025—it’s time to migrate to Drupal 10! Learn about the many benefits of Drupal 10 and find migration tools in our resource center.
Comment | File | Size | Author |
---|---|---|---|
#1 | feeds-system_alter-2390297-1.patch | 3.56 KB | twistor |
Comments
Comment #1
twistor CreditAttribution: twistor commentedComment #2
MegaChriz CreditAttribution: MegaChriz commentedI've looked at the patch and noticed a few things, but I'm not sure if they are a real problem, so I leave the issue status to "Needs review".
feeds_system_info_alter()
only iterates over modules that implementhook_feeds_plugins()
. This means that Feeds plugins that declare dependency modules that do not implement that hook will not be marked as required. Best example: Taxonomy term processor. The Taxonomy module can still be disabled even if an importer depends on it.Just removing the condition
!module_hook($file->name, 'feeds_plugins')
may have influence on performance as then for every module Feeds recalculates dependencies for all importers.Maybe it's better to calculate all dependencies once and cache that into a static variable? Only downside is then that all importers will always be loaded when visiting the module page, even when there are no Feeds extension modules.
Comment should end in an period instead of a comma.