Users need to figure out by magic that the settings must be saved. Let's show them a help message.

The currently proposed message is:
"Changes made to mapping configuration will not be stored until the Save button is clicked."

If anyone has a better idea, I'm all ears.

Support from Acquia helps fund testing for Drupal Acquia logo

Comments

twistor’s picture

Status: Active » Needs review
FileSize
634 bytes
twistor’s picture

twistor’s picture

twistor’s picture

Issue summary: View changes
MegaChriz’s picture

Assigned: Unassigned » MegaChriz

I had this idea as well a few weeks ago. I even started to work on a patch. In my version of the patch the mapper you change configuration for got a star attached as an indication which mapper you changed config for.
I hope to take a look at your patch in a few days and eventually merge it my work-in-progress patch. (I don't have the patch within reach right now.)

MegaChriz’s picture

Patch review

I've tested your patch in #3 and one thing I noticed the message disappears as soon you click to the wheel for any target configuration. The message reappears when clicking the "Update" button, but not when clicking the "Cancel" button. I think it's better if the message stays until you click the "Save" button.

Message proposal

In my original patch (not posted here) I had the message set to

* All changes are stored temporarily. Click Save to make your changes permanent.

This is the same message as what is used in Views. I had done this to reduce the amount of strings to be translated.

However, I think "All changes" is not very explicit in the context of Feeds, so I now I have changed the message to

* Changes made to mapping configuration are stored temporarily. Click Save to make your changes permanent.

New patch

Instead of using drupal_set_message(), I added a form markup entry that only appears if $form_state['mapping_settings'] is not empty. This variable is set in feeds_ui_mapping_form_multistep_submit(). This way, the message doesn't disappear while changing other target configurations. Additionally, a star is added to the target name to indicate which target config changed. See also attached image.

MegaChriz’s picture

Assigned: MegaChriz » Unassigned
twistor’s picture

Status: Needs review » Needs work

Nice! I wasn't sure about the text either, what you have looks good.

Can we wrap the asterix in <span class="warning">*</span>?. Haha, I probably could have added it to patch patch faster than typing it in here. Other than that, it looks good. I can fix it up on commit, but want to let this sit for a bit longer.

MegaChriz’s picture

Adding a <span> around the asterix is a nice one. Then the asterix gets a brown color (as set in system.messages.css).
Now that the issue is still open, I wondered if the term "mapping configuration" is right as the column in which you set such configuration is called "target configuration". Maybe we should rename it to "target configuration" in the warning message?

MegaChriz’s picture

Status: Needs work » Needs review
FileSize
3.11 KB
1.88 KB
104.38 KB

I changed the warning message to "* Changes made to target configuration are stored temporarily. Click Save to make your changes permanent." and added the span-tags around the asterisk as suggested in #8.

  • twistor committed c1b3f09 on 7.x-2.x authored by MegaChriz
    Issue #2305929 by twistor, MegaChriz: Show message that mapping settings...
twistor’s picture

Status: Needs review » Fixed

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.