Title says it all.

CommentFileSizeAuthor
#2 1066806-feeds-entity-hooks.patch4.19 KBDave Reid
#1 1066806-feeds-entity-hooks.patch4.2 KBDave Reid
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

Dave Reid’s picture

Dave Reid
he/him
Primary language English
Location Nebraska USA
CreditAttribution: Dave Reid commented
Status: Active » Needs review
FileSize
1066806-feeds-entity-hooks.patch4.2 KB
Dave Reid’s picture

Dave Reid
he/him
Primary language English
Location Nebraska USA
CreditAttribution: Dave Reid commented
FileSize
1066806-feeds-entity-hooks.patch4.19 KB

Note the patch also adds a hook_entity_load() so that feed items have a property 'feed_nid' for their source feed.

Dave Reid’s picture

Dave Reid
he/him
Primary language English
Location Nebraska USA
CreditAttribution: Dave Reid commented
Assigned: Unassigned » Dave Reid
Dave Reid’s picture

Dave Reid
he/him
Primary language English
Location Nebraska USA
CreditAttribution: Dave Reid commented
Status: Needs review » Fixed

Committed to Git.
http://drupalcode.org/project/feeds.git/commit/da8d974

Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for 2 weeks with no activity.

Bevan’s picture

Bevan CreditAttribution: Bevan commented
Status: Closed (fixed) » Needs review

#1033202: [Meta] Generic entity processor has a patch which also adds hook_entity_insert/update/delete, but wraps the body of each implementation in 

if (!in_array ($type, array ('node', 'user', 'taxonomy_term'))) {
  ...
}

I have not looked into why, or which is correct, but though it was worth noting here and re-reviewing this patch.

Dave Reid’s picture

Dave Reid
he/him
Primary language English
Location Nebraska USA
CreditAttribution: Dave Reid commented

Probably because that's the only entities that feeds.module used to support - but its an unnecessary restriction - we can operate on all entities no problem.

Bevan’s picture

Bevan CreditAttribution: Bevan commented
Status: Needs review » Closed (fixed)

Thanks for the clarification.