Support from Acquia helps fund testing for Drupal Acquia logo

Comments

Dave Reid’s picture

Yes it's definitely getting ported at some point soon. I've been working on stabilizing the Redirect API which the FeedBurner module will depend on.

tsvenson’s picture

Thanks for the info. Took a look at the Redirect API module and have to agree its a great addition that will centralise a lot of functions modules mentioned on the project page uses.

int’s picture

subscribe

int’s picture

Priority: Normal » Major

Drupal 7.0-rc1 out

Dave Reid’s picture

Priority: Major » Normal

I'm aware. Stop mass bumping issues.

wasare’s picture

+1

jackbravo’s picture

subscribe

discursives’s picture

subscribe

eagereyes’s picture

I like the idea of a unified common module, but for the moment that means no feedburner module for D7. That means I can't port my site, and I'm sure there are many others who depend on this module.

jackbravo’s picture

Just complaining or asking when will this be ready doesn't help.

If there is something you can do about this (code, resources, etc) then by all means express it, but if you just say, "I want this now", no one will listen.

CSCharabaruk’s picture

subscribing

v.zhakov’s picture

subscribe

kemitix’s picture

subscribe

nunof’s picture

subscribing

vadim s. sabinich’s picture

+1 =)

elgandoz’s picture

subs

killua99’s picture

subs +1

Subbo’s picture

subscribe

branana’s picture

Initial port, not using the Redirect module for redirection yet

https://github.com/bran/feedburner

The patch is against 6.x-1.x branch

branana’s picture

Sorry I don't think drupal.org likes that hash mark in the file name

branana’s picture

This patch updates all the queries to d7 equivalent, and a few small updates for d7. This patch works on top of the one I posted above.

branana’s picture

This patch works on top of the one I posted above. This patch makes "Unburn" work. Fixed all the broken links that were pointing to admin/build rather than admin/structure

branana’s picture

Update the way xmlrpc is called to D7 way

branana’s picture

This patch combines all changes up to this point against 6.x-1.x HEAD

includes:
#20
#21
#22
#23

yuriy.babenko’s picture

Reviewed 956872-all_porting_up_to_march28-comment-24-D7.patch; looks good.

Some errors/warnings, but nothing critical, and the module still works:

1. Checked out the latest 6.x-1.x, applied patch in comment 24, enabled module and got:

DatabaseSchemaObjectExistsException: Table <em class="placeholder">feedburner</em> already exists. in DatabaseSchema->createTable() (line 630 of /includes/database/schema.inc).

2. After 'unburning' a feed:

Notice: Undefined index: unburn in feedburner_unburn_form_submit() (line 211 of /sites/all/modules/feedburner/feedburner.admin.inc).

Anonymous’s picture

Sub

7wonders’s picture

+1

kristoferaberg’s picture

sub

garrettrayj’s picture

+1

klipnov’s picture

+1

mjross’s picture

Category: feature » task

Subscribing

jeffwidman’s picture

subscribe

jeffwidman’s picture

subscribe

branana’s picture

Status: Active » Needs review
FileSize
55.16 KB

This patch is all inclusive on 6.x-1.x HEAD, including fixes for comment #25.

my working copy is at https://github.com/bran/feedburner

Dave Reid’s picture

Status: Needs review » Needs work

The D7 version is going to be rewritten to use the APIs provided in the Redirect module, so this is not just a port.

ceefour’s picture

Also waiting for this :-)

mailking’s picture

+1

Zanel’s picture

+1 sub

geerlingguy’s picture

Subs.

Shane Birley’s picture

Subscribing for the awesomeness.

geerlingguy’s picture

Title: Drupal 7 version » Drupal 7 version of FeedBurner

Tagging the title for those following this issue in Tracker (please allow this change—it's oh-so-helpful for people who are following about 25 other 'Drupal 7 version' or 'Drupal 7 port' issues...).

scito’s picture

The D7 version is going to be rewritten to use the APIs provided in the Redirect module, so this is not just a port.

Cool!
What about doing a 7.x-1.x with a direct port of 6.x-1.x using the provided patches and later a 7.x-2.x using the new Redirect module API?

criscom’s picture

subscribing

tky’s picture

subscribing

scito’s picture

FileSize
452 bytes

example.com/taxonomy/term/11/0/feed does not work anymore in Drupal 7.

It should be without /0 in Drupal 7.

The patch is against https://github.com/bran/feedburner.

A related issue comment of the RSS Permissions module: http://drupal.org/node/945462#comment-3938962.

@branana: Thanks for your port.

scito’s picture

FileSize
1.49 KB

A patch for fixing some warnings:

Warnings on view:
Warning: Parameter 1 to feedburner_node_view() expected to be a reference, value given in module_invoke_all() (line 819 of /home/proj/web/dev/d7git/includes/module.inc).

fix: function feedburner_node_view($node, $view_mode = 'full', $langcode = NULL) {
reference: http://api.drupal.org/api/drupal/modules--node--node.api.php/function/ho...

Notice: Undefined property: stdClass::$in_preview in feedburner_node_view() (line 182 of /home/proj/web/dev/d7git/sites/all/modules/feedburner/feedburner.module).

fix: if (!empty($node->in_preview) && user_access('view feedflare')) {
modification idea from: http://drupalcode.org/project/location.git/blobdiff/4ad4c6d9ddc013a7d2c3...

XML RPC warnings after node edit:

Warning: key() expects parameter 1 to be array, string given in _xmlrpc() (line 557 of /home/proj/web/dev/d7git/includes/xmlrpc.inc).

Warning: Invalid argument supplied for foreach() in xmlrpc_request() (line 380 of /home/proj/web/dev/d7git/includes/xmlrpc.inc).

fix: $result = xmlrpc('http://ping.feedburner.google.com/', array('weblogUpdates.ping' => array($name, $url)));
reference: http://api.drupal.org/api/drupal/includes--common.inc/function/xmlrpc/7

The patch is against https://github.com/bran/feedburner. Patch of #45 is not included.

jonasdowney’s picture

subscribe

apb1991’s picture

Sub

retolist’s picture

Subscribe

monican’s picture

+1 I agree with #42. Great job branana and scito!

Satri’s picture

subscribing

ktleow’s picture

Subscribe

erdembey’s picture

Subscribing

carusen’s picture

subscribing - we need a port for Drupal 7.

maxperience’s picture

Subscribe

vb’s picture

The patch is against https://github.com/bran/feedburner.
You can see it in action on http://drupalbridge.org/en and download the working module here http://drupalbridge.org/en/feedburner-module-drupal-7-version.

ibex’s picture

@vb Have you made any additional fixes compared to #45 and #46?

vb’s picture

@ibex, yes

nelslynn’s picture

@vb... awesome, almost there. From your site, you have two Feeds. The one set up with FeedBurner works great, but the "This site (RSS)" does not when using FireFox and yahoo reader. When I try to validate your "This Site (RSS)" with http://feedvalidator.org, it throws the same errors I get. Those are:
- Missing atom:link with rel="self"
- description should not contain relative URL references (how do you change all Feed relative URLs into Absolute)

I'm getting the same errors above. FeedBurner will not accept a Feed URL that does not validate.

Can anyone comment on how to fix the two errors above in order to complete the configuration of this module?

neurojavi’s picture

i've tested the module linked in #56 and seems to work for me.
I've tested it with a rss view.

I've found two little problems:
- A JS error when typing in admin/structure/feedburner/burn/ (in any of the two fields)
- An error when submiting admin/structure/feedburner/burn/ and url in fedburner feed field has a ?format=html argument as recomended in the following link to show browser friendly page: http://www.google.com/support/feedburner/bin/answer.py?hl=en&answer=79738

What about a dev version that allows us better testing and issue filling?

Thanks.

Javi.-

erdembey’s picture

I think that an updated dev for 7.x would be great.
We can test and create issues for correct branch.

Thanks

Anonymous’s picture

Hi
I didnt install any module for feedburner. I just opened feedburner account, in the Original feed field type http://vision4life.in/rss.xml - Feed address column typed feedname (any choice). Then publicise,optimize all done. saved. Downloaded and saved one feedicon in /sites/default/files/images. Added a block, inserted image, linked Only local images are allowed..

Drupal default Rss syndication block is none. when clicking on the feedicon, it is showing feedburner feeds. I never knew that a module is available. I think it is working ok without any module. But I am also getting same error Missing atom:link with rel="self". I dont now where to add that. Can any one help?

JJSON’s picture

sub

dantz’s picture

The linked Module in #56 works fine for me on a Views-Feed.

ajaysolutions’s picture

subscribe

Murz’s picture

subscribe

Krusnik02’s picture

No, rediresct is not enough. There could be two problems:
1. How to automatically change RSS Icon ursl in the end of page for User Foums?
2. I have 10+ Feeds on my portal and I can not create separate block for each of them...
3. Local URS: when burning feeds to feedBurner local Links not transfered automatically and they are treated as FeedBurner Local.

So let us develop something
+1

minnur’s picture

Subscribing.

hansfn’s picture

Dave, I know you are extremely busy, but shouldn't you have created a 7.x-1.x branch / version (as suggested above) long time ago? Perfection is good, but not when nothing happens. For non-developers there effectively isn't a working Drupal 7 version of this module and it's soon a year since Drupal 7.0 was released. This is very sad.

I'm suggesting that some of the people contributing patches is offered to co-maintain this module.

Shane Birley’s picture

@hansfn, I agree some could co-maintain the blog but, as you pointed out, @davereid is very busy. There is a lot of working going on with the Redirect module that is required to be finished before this module is updated.

@davereid, you rock man. Any update would not go amiss (re: redirect APIs, etc).

marvil07’s picture

If you are using this module to redirect your main feed, maybe you would like to do it manually with redirect until this module is ready:

/**
 * Implements hook_menu_alter().
 */
function youcustommodule_menu_alter(&$items) {
  // Redirect to feedburner.
  $items['rss.xml']['page callback'] = 'youcustommodule_node_feed';
}

/**
 * Menu callback override for rss.xml
 *
 * Redirect to feedburner.
 */
function youcustommodule_node_feed() {
  $feedburner_url_redirect = new stdClass;
  $feedburner_url_redirect->redirect = 'http://feedproxy.google.com/yoururlhere';
  redirect_redirect($feedburner_url_redirect);
}
tsvenson’s picture

@marvil07

A simpler, more efficient way, is to just add the following to the top of the .htaccess file:

RewriteCond %{HTTP_USER_AGENT} !FeedBurner
RewriteRule ^"path to site feed"$ "fullt URL to Feedburner feed" [R=temp,L]

Replace the path/URL without the quotes.

lameei’s picture

I want to upgrade my blog. Is there any new development?

intropedro’s picture

Subscribing +1

margokw’s picture

It is beyond ridiculous that there is no Drupal 7 version out yet. 2 years? Really?

deekayen’s picture

Re #77: @margokw - Dave maintains a lot of modules. Make a patch or thank him for what he did. Don't abuse. See also http://beta.openpredictionmarkets.org/node/8

jordan8037310’s picture

sub

lsolesen’s picture

@intropedro and @jordan8037310 <-- Please use the big follow button in the top right corner instead of subscribe comments. Thanks!

intropedro’s picture

In the the big follow button in the top right corner I see the text "Following" and if I put the mouse hover it, the text change to "Unfollow" with backbroung green.

lsolesen’s picture

@intropredro You started following when you added the subscribe comment. Next time do no make a subscribe comment. Just click the button, and you will follow the subject, but not notify everyone else on the comment, that you are following when you are not adding anything to the issue.

anniegreens’s picture

At this point, I suggest someone who has created a direct port for D7 request co-maintainership via the proper Drupal method: http://drupal.org/node/251466. The fact that this thread is the longest and most active in the issue queue for this module is the exact reason this resource is available.

Dave's desire to recreate the D7 version to rely on the Redirect API is valiant and not without purpose, but in the meantime there is no reason why a 7.x-1.x version cannot be made as a direct port. When Dave gets his version created it can be a 7.x-2.x branch, as suggested above.

Anonymous’s picture

Note that the Redirect project page has been revised to remove the suggestion that it will provide Feedburner functionality:

http://drupal.org/node/3287/revisions/view/1490084/1828558

eranks’s picture

I am having a lot of issues getting this module formatted correctly. Is someone willing to give me a little help?

HongPong’s picture

the 2 active forks i found on github: https://github.com/ceefour/feedburner/commits/
https://github.com/bran/feedburner
Probably someone could take up the reins for @DaveReid but does anyone understand the Redirect module situation?? If it's ok now maybe we can start trying to roll some patches together.

Anonymous’s picture

@DaveReid seems to have pretty much explicitly abandoned this module. (He removed the statement on the Redirect page that it would eventually incorporate Feedburner, he hasn't made any commits to Redirect in more than a half a year, and nothing on this module in two years.)

So, we can be glad that he originated this, and yes, it would be good if someone were to take it over (using the abandoned module process if necessary).

Personally, I just used the recipe at:
http://support.google.com/feedburner/bin/answer.py?hl=en&answer=78464&to...
which is quite simple and easy.

This requires that you can edit your .htaccess file, however, and some people on shared hosting won't have the privileges to do that (or maybe even the skillz).

Alternatively, you can use the Redirect module with hidden feeds (also explained on the support.google page). Again this is pretty easy, but it would be good to have a method that will work without any understanding required at all.

Another note: Google seems to be fading Feedburner. It's increasingly buggy and apparently unsupported. I won't be surprised if it disappears altogether in a year or two.

So, it would be good to think about alternate methods for accomplishing the same things, ideally in a pure-Drupal solution.

deekayen’s picture

@HongPong, I think you're over-selling the "active forks" part of your post. One of them has one commit this year, the other has two commits this year.

Juc1’s picture

@ a1tsal, thanks for your link:

RewriteEngine on
RewriteCond %{HTTP_USER_AGENT} !FeedBurner
RewriteRule ^index\.xml$ http://feeds.feedburner.com/YOURFEEDADDRESS [R,L]

Does that only work for one RSS feed - what if I have numerous RSS feeds?

Thanks

Anonymous’s picture

You need one copy of that per feed; you substitute the feed address for YOURFEEDADDRESS in the text.

Shane Birley’s picture

Issue summary: View changes
Status: Needs work » Closed (outdated)