Problem/Motivation

At time-of-writing, about 30 sites use the 3.x version of the module, but it doesn't have a stable release covered by security advisories.

I'd like to get this project to a state where the maintainers (myself included) feel comfortable making a stable 3.0.0 release, marking it as "Supported" and "Recommended", and opting into security advisory coverage.

Proposed resolution

Determine what we need to do to get a stable release of this module, then do those things!

Remaining tasks

  1. Fix issues blocking a release (see below)
  2. Make a beta release
  3. Make an RC release
  4. Make a full release

The issues blocking a release...

  1. #3480990: Add automated tests
  2. #3209858: Missing config_export results in a fatal error on Drupal 9
  3. #3304307: Report page is missing / not available
  4. #3420616: Feedback collection route is using non existent permission
  5. #3481576: Feedback message type entity doesn't declare its success_message property
  6. #3481797: Add database updates test
  7. #3481798: Add tests for views component
  8. #3588194: Feedback type does not show selected option on block form

Some issues that would be nice-to-have for a release, but aren't technically blockers are...

  1. #3481971: Re-add optional Browscap integration in 3.x version
  2. #3481980: Switch to new constructor/dependency-injection pattern
  3. #3481982: Simplify composer.json
  4. #3586794: Error: Route "entity.feedback_message_type.canonical" does not exist
  5. #3586777: Install ddev/ddev-drupal-contrib 1.1.5
  6. #3586798: Add drush to the development environment
  7. #3586801: PHPStan level 1
  8. #3586803: PHPStan level 5
  9. #3588845: Declare strict_types in all PHP files
  10. #3588867: Drop support for core 9, 10.0 through 10.4, 11.0, 11.1
  11. #3588869: Add missing FeedbackUpdateHookTest::defaultTheme

Some issues that we need more information from the participants are...

  1. (none at this time)

Other issues that are Open Bug reports and Tasks filed against all 3.0.* and all 3.* branches, which the maintainers do not consider to be blockers are...

  1. (none at this time)

Comments

mparker17 created an issue. See original summary.

mparker17’s picture

mparker17
he/him
Primary language English
Location UTC-5
commented

#3420616: Feedback collection route is using non existent permission is fixed now!

mparker17’s picture

mparker17
he/him
Primary language English
Location UTC-5
commented
Issue summary: View changes

Adding #3481576: Feedback message type entity doesn't declare its success_message property to blockers; note it's already done.

mparker17’s picture

mparker17
he/him
Primary language English
Location UTC-5
commented
Issue summary: View changes

Adding #3481798: Add tests for views component as a release-blocker because it's the only part of the module missing tests.

Adding #3481797: Add database updates test as a release-blocker because it's useful to have a baseline before a release.

Also #3480990: Add automated tests is done now, yay!

mparker17’s picture

mparker17
he/him
Primary language English
Location UTC-5
commented

#3304307: Report page is missing / not available is now done too.

mparker17’s picture

mparker17
he/him
Primary language English
Location UTC-5
commented

#3209858: Missing config_export results in a fatal error on Drupal 9 is also done.

mparker17’s picture

mparker17
he/him
Primary language English
Location UTC-5
commented
Issue summary: View changes

Added #3481980: Switch to new constructor/dependency-injection pattern as a nice-to-have.

mparker17’s picture

mparker17
he/him
Primary language English
Location UTC-5
commented
Issue summary: View changes

Added #3481982: Simplify composer.json as a nice-to-have.

mparker17’s picture

mparker17
he/him
Primary language English
Location UTC-5
commented
Issue summary: View changes

Adding #3481971: Re-add optional Browscap integration in 3.x version as a nice-to-have.

mparker17’s picture

mparker17
he/him
Primary language English
Location UTC-5
commented
Issue summary: View changes

Add #3481983: Add tests for block plugin as a blocker.

mparker17’s picture

mparker17
he/him
Primary language English
Location UTC-5
commented
Issue summary: View changes

I have a bit of time this month to work on contrib modules! So I'm working on the Feedback module, as I feel it has languished in an almost-ready-to-release state for a while!

Today I spent some time closing old issues for unsupported versions in the queue; and making some changes to the 3.x branch to make it easier for me to maintain and make releases on that branch.

Other than the coding standards changes (which I made directly to the 3.x branch), I've been filing tickets as records of the things that happened (as well as giving me something to link to in the release notes).

The ones I've done so far to make my maintaining-life easier are:

  1. #3586794: Error: Route "entity.feedback_message_type.canonical" does not exist
  2. #3586777: Install ddev/ddev-drupal-contrib 1.1.5
  3. #3586798: Add drush to the development environment
  4. #3586801: PHPStan level 1
  5. #3586803: PHPStan level 5

Soon I will work on the outstanding test issues, then make another release.

mparker17’s picture

mparker17
he/him
Primary language English
Location UTC-5
commented
Issue summary: View changes

Turns out #3588194: Feedback type does not show selected option on block form is a blocker and duplicates #3481983: Add tests for block plugin

mparker17’s picture

mparker17
he/him
Primary language English
Location UTC-5
commented
Issue summary: View changes
Status: Active » Needs review

All the issues previously blocking a release are now fixed; but I can think of a handful of things to do before making a beta release (I will update this issue with links to them when I have created the issues).

mparker17’s picture

mparker17
he/him
Primary language English
Location UTC-5
commented
Issue summary: View changes

Adding #3588845: Declare strict_types in all PHP files

mparker17’s picture

mparker17
he/him
Primary language English
Location UTC-5
commented
Issue summary: View changes

Adding #3588867: Drop support for core 9, 10.0 through 10.4, 11.0, 11.1 and #3588869: Add missing FeedbackUpdateHookTest::defaultTheme

I'm going to make one more alpha release with the work completed thus far and then wait a bit to see if any issues are reported before making the beta release.