Comments

grisendo’s picture

Status: Active » Needs review
StatusFileSize
new4.94 KB

I attach a patch

yannickoo’s picture

Status: Needs review » Needs work
+++ b/fe_block.module
@@ -504,6 +508,15 @@ function fe_block_settings_features_revert($module_name = NULL) {
+    }    ¶

Oops, there are whitespaces, please remove them :)

grisendo’s picture

Status: Needs work » Needs review
StatusFileSize
new4.93 KB

Removed!

grisendo’s picture

Better this one, that makes extra checks of existing/non-existing roles.

grisendo’s picture

Ok, I'm becoming crazy... I uploaded the same many times ¬¬ this is the good one (I hope!).

yannickoo’s picture

Status: Needs review » Needs work

Some nitpicks.

  1. +++ b/fe_block.module
    @@ -138,6 +138,10 @@ function fe_block_settings_features_export_render($module_name = '', $data) {
    +      // Add ajaxblocks support.
    

    The name of the module is "Ajax Blocks" not "ajaxblocks".

  2. +++ b/fe_block.module
    @@ -717,6 +730,68 @@ function _fe_block_settings_update_block_cache_alter($block){
    +
    ...
    +
    ...
    + *
    ...
    +
    ...
    +
    
    @@ -1212,6 +1287,95 @@ function _fe_block_get_block_i18n_block_language($block) {
    +
    ...
    +
    ...
    +
    ...
    +
    

    Why did you insert those extra blank lines?

  3. +++ b/fe_block.module
    @@ -717,6 +730,68 @@ function _fe_block_settings_update_block_cache_alter($block){
    +    // Anonymous and Registered roles are special.
    

    I would write "Special handling for anonymous and authenticated users.". Sounds more drupalish.

yannickoo’s picture

Ouch, Dreditor did some crazy stuff. With "extra blank lines" I mean the blank lines right after the function start and before the function end.

grisendo’s picture

I forgot to ask, any help to detect final lines whitespaces?

grisendo’s picture

Status: Needs work » Needs review

Forgot to change the status :D

grisendo’s picture

Issue summary: View changes

Hi,

Any new about this? I am still managing patched version in my projects :P