Needs review
Project:
Features Extra
Version:
7.x-1.x-dev
Component:
FE Block
Priority:
Normal
Category:
Feature request
Assigned:
Unassigned
Reporter:
Created:
13 Aug 2013 at 13:39 UTC
Updated:
29 Oct 2015 at 15:39 UTC
Jump to comment: Most recent, Most recent file
Comments
Comment #1
grisendo commentedI attach a patch
Comment #2
yannickooOops, there are whitespaces, please remove them :)
Comment #3
grisendo commentedRemoved!
Comment #4
grisendo commentedBetter this one, that makes extra checks of existing/non-existing roles.
Comment #5
grisendo commentedOk, I'm becoming crazy... I uploaded the same many times ¬¬ this is the good one (I hope!).
Comment #6
yannickooSome nitpicks.
The name of the module is "Ajax Blocks" not "ajaxblocks".
Why did you insert those extra blank lines?
I would write "Special handling for anonymous and authenticated users.". Sounds more drupalish.
Comment #7
yannickooOuch, Dreditor did some crazy stuff. With "extra blank lines" I mean the blank lines right after the function start and before the function end.
Comment #8
grisendo commentedI forgot to ask, any help to detect final lines whitespaces?
Comment #9
grisendo commentedForgot to change the status :D
Comment #10
grisendo commentedHi,
Any new about this? I am still managing patched version in my projects :P