Problem/Motivation

Currently in the 'exclude' assignment plugin we (optionally) exclude extension-provided configuration.

However, the install profile can legitimately override configuration originally provided by another extension.

Background

Module and theme install methods throw a PreExistingConfigException if the extension provides a configuration item with the same name as one that's already present in the active configuration storage.

However, as explained in the code comments in ModuleInstaller::install(), an exception is made for install profiles:

// Install profiles can not have config clashes. Configuration that
// has the same name as a module's configuration will be used instead.

See also ExtensionInstallStorage::getAllFolders():

    // The install profile can override module default configuration. We do
    // this by replacing the config file path from the module/theme with the
    // install profile version if there are any duplicates.

This approach was introduced in #2140511: Configuration file name collisions silently ignored for default configuration.

Proposed resolution

Already completed: add a property extension_provided to items in the config collection that we test before packaging an item.

Remaining tasks

On the feature edit form, make an exception for profiles. When editing them, allow adding configuration marked extension_provided.

User interface changes

API changes

Comments

nedjo’s picture

Project: Configuration Packager » Features
Version: 8.x-1.x-dev » 8.x-3.x-dev
nedjo’s picture

nedjo’s picture

nedjo’s picture

Issue summary: View changes

  • nedjo committed d3f4626 on 8.x-3.x
    Issue #2443589 by nedjo: add flag allowing extension-provided...

  • nedjo committed d9eaa14 on 8.x-3.x
    Issue #2443589 by nedjo: add exception to dependency processing for...

  • nedjo committed 97a39b5 on 8.x-3.x
    Issue #2443589 by nedjo: add exception to bulk assigning by type for...

  • nedjo committed 24c397d on 8.x-3.x
    Issue #2443589 by nedjo: back out of overly-complex pseudo-package...
nedjo’s picture

Issue summary: View changes
nedjo’s picture

Status: Active » Fixed

I believe this was fixed and just not marked so.

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.