Support for Drupal 7 is ending on 5 January 2025—it’s time to migrate to Drupal 10! Learn about the many benefits of Drupal 10 and find migration tools in our resource center.
because drupal_static is cool
Comment | File | Size | Author |
---|---|---|---|
#2 | features_drupal_static-1983022-2.patch | 3 KB | undertext |
features_drupal_static.patch | 2.97 KB | hefox | |
Comments
Comment #1
Angry Dan CreditAttribution: Angry Dan commentedThis patch is out of date and needs calls to drupal_static() to be by reference:
Should be (note the &):
But definitely +1 for this - features is a pig for memory, so moving to the static caching system is a good step away to being better able to manage memory usage (via resets).
Comment #2
undertext CreditAttribution: undertext commentedComment #3
undertext CreditAttribution: undertext commentedComment #4
bojanz CreditAttribution: bojanz commentedWe have this running in production for months now.
Comment #5
hefox CreditAttribution: hefox commentedthanks
Comment #7
Taran2LDon't see this code in the features codebase. Has this patch been committed at all?
Issue #2143765: features_modules_enabled() doesn't work when features_load_feature cache doesn't include the feature got me here. Have the same issue with 7.x-2.2
Comment #8
Taran2LSeems like it was closed before actual commit was done. Reverting status back to "Reviewed & tested by the community"
Comment #11
joelpittetIt looks like this may need a re-roll as well.
Comment #12
lsolesen CreditAttribution: lsolesen commented@joelpittet and @Taran2L I am pretty sure that this has been committed. I tried a reroll just now and ended up with an empty diff. So setting back to Fixed. If you disagree, please reopen again.
Comment #13
joelpittet@lsolesen I think you are correct, just the committed code is just slightly different than the patch for the resetting approach and no commit hash showed up in the issue queue.
Comment #15
Taran2LHi @all,
Sorry for the confusion: I've had a false impression, that my issue is cache-related.
Actually, it's related to the fact, that Features module fails to include files when module(s) are being enabled.
See more #2143765-6: features_modules_enabled() doesn't work when features_load_feature cache doesn't include the feature