Problem with revert contexts in features [#1921344]

Hello

I use module metatag, and I have problem with revert "features" containing contexts.

Step by step instruction for reproduce problem:

1. You should have last version of module metatag;
2. First, create custom metatag setting for special url on this page "admin/config/search/metatags/context";
3. Add your new context into "feature";
4. Copy your "feature" with new context to separate server (or remove this context via interface for quickly testing on your local server);
5. You will see that "feature" with your context have status overriden;
6. When you will revert feature, your new context not will be created (and not will be reverted, but will be removed from database, in case if it was created earlier);
7. "Feature" with your context always will be overriden.

I have investigated the file features.context.inc. The function context_features_revert is only remove contexts, but not create new contexts that are contained in the my "feature".

This small patch solves the problem.

I will be very grateful if you add me as author of commit.
Thanks!

Comment	File	Size	Author
	fix-revert-feature-contexts.patch	585 bytes	eugene.ilyin

Support from Acquia helps fund testing for Drupal Acquia logo

Comments

Comment #1

eugene.ilyin CreditAttribution: eugene.ilyin commented 27 February 2013 at 03:17

Status:

Active

» Needs review

Comment #2

eugene.ilyin CreditAttribution: eugene.ilyin commented 7 March 2013 at 10:20

Any news? Review my patch please.

Comment #3

eugene.ilyin CreditAttribution: eugene.ilyin commented 22 March 2013 at 11:52

Who can see my patch please?

Comment #4

mpotter CreditAttribution: mpotter commented 26 March 2013 at 18:44

Status:

Needs review

» Closed (works as designed)

Contexts are ctools exportables that only live in code and not in the database. Something else must be happening on your site as I cannot reproduce this. My context's are exported fine.

When you export a context to a feature, you should get a myfeature.context.inc file that contains your hook function: myfeature_context_default_contexts(). The Context module calls this hook to allow new contexts to be added via code. No database entires are made for this. This is how all "true" features work (ctools, views, etc).

So reverting should not perform any sort of "save".

The fact that your feature was marked as overridden in #5 sounds like your problem. Did you be sure to clear the drupal cache on the new site after installing the feature. You must always clear Drupal cache "drush cc all" after enabling new features for them to show up properly.