There are too much problems that I found when trying to make this module works
Eg:
- On status page, it will threw errors:
http://monosnap.com/image/jc7Q7dKPWEDd9riEndEQzlu6ue6ANw
http://monosnap.com/image/O0LLAY94fXXPOdXVBv8KeElhoVBJGv
- On Rules trigger if there are permission check it will threw a white page, because wrong function called.
I changed it manually to correct functions and it's give an infinite loop
- Etc

CommentFileSizeAuthor
#6 fb_autopost-hook_requirements_value-2301719-6-7.x.patch1.56 KBguypaddock
#4 fb_autopost-hook_requirements_value-2301719-4-7.x.patch624 bytesguypaddock
#3 2016-07-09 - 2301719 - No value.PNG10.38 KBguypaddock

Comments

e0ipso’s picture

e0ipso
Primary language Catalan
Location Can Picafort
commented
Title: 7.12 version is broken/ unusable » hook_requirements warnings.

I'm curious why this is only happening to you since there seems to be a lot of sites using this release.

Can you provide more info about possible interactions? Did you trace those problems back to fb_autopost? If so, can you share your findings (exact function names, line numbers, …)?

Thanks for reporting!

e0ipso’s picture

e0ipso
Primary language Catalan
Location Can Picafort
commented

Please, when reporting back specify how/where you installed the Facebook PHP SDK library and the contents of it.

guypaddock’s picture

guypaddock commented
StatusFileSize
new 2016-07-09 - 2301719 - No value.PNG10.38 KB

I can confirm that hook_requirements is not properly implemented in the module.

Visiting admin/reports/status when the Facebook SDK is not installed yields this error:

Notice: Undefined index: value in theme_status_report() (line 2603 of modules/system/system.admin.inc).

This is because it is not returning a "value" key (see attached screenshot).

guypaddock’s picture

guypaddock commented
StatusFileSize
new fb_autopost-hook_requirements_value-2301719-4-7.x.patch624 bytes

The attached patch should correct at least the status report page warnings.

guypaddock’s picture

guypaddock commented
Status: Active » Needs review
guypaddock’s picture

guypaddock commented
StatusFileSize
new fb_autopost-hook_requirements_value-2301719-6-7.x.patch1.56 KB

Corrected a few more, related issues in this section.