Circular references on enabling fastly module

Not sure what issue is here exactly. Maybe some more information would be helpful.
Tried to download and enable the module and did not get any issues.
Dependency injection in this case is ok and recommended way to go since CacheTagsInvalidator is a class and what you are referring to are methods of that class. In your proposed patch you are basically removing recommended DI and using those injected services as a static calls inside a method which is not static which is a bad practice.

As you are on 9.3 please try the 4.0.x branch.

I'm seeing the same issue on 4.x branch, on a site running a multisite installation using Domain module.

│ php [2023-11-02T13:05:58.175283+02:00] php.ERROR: Symfony\Component\DependencyInjection\Exception\ServiceCircularReferenceException: Circular reference detected for service "domain.route_provider", path: "options_request_listener -> domain.route_provider -> cache_tags │
│ .invalidator -> fastly.cache_tags.invalidator -> fastly.api -> fastly.services.webhook -> router -> router.no_access_checks". in Drupal\Component\DependencyInjection\Container->get() (line 147 of /var/www/html/web/core/lib/Drupal/Component/DependencyInjection/Containe │
│ r.php). {"severity_level":3,"exception":"[object] (Symfony\\Component\\DependencyInjection\\Exception\\ServiceCircularReferenceException(code: 0): Circular reference detected for service \"domain.route_provider\", path: \"options_request_listener -> domain.route_provi │
│ der -> cache_tags.invalidator -> fastly.cache_tags.invalidator -> fastly.api -> fastly.services.webhook -> router -> router.no_access_checks\". at /var/www/html/web/core/lib/Drupal/Component/DependencyInjection/Container.php:147)"} {"referer":"","ip":"[ip_redacted]"," │
│ request_uri":"https://[domain_redacted]/","uid":0,"user":""}                                                                                                                                                                                              │
│ php NOTICE: PHP message: Uncaught PHP Exception Symfony\Component\DependencyInjection\Exception\ServiceCircularReferenceException: "Circular reference detected for service "domain.route_provider", path: "options_request_listener -> domain.route_provider -> cache_tags. │
│ invalidator -> fastly.cache_tags.invalidator -> fastly.api -> fastly.services.webhook -> router -> router.no_access_checks"." at /var/www/html/web/core/lib/Drupal/Component/DependencyInjection/Container.php line 147

The site in question has 3 domains enabled.

@operinko
This looks like something possibly related to domain module instead of fastly module.
There were at least 2 issues on domain and domain site settings module reported for similar issues:
https://www.drupal.org/project/domain/issues/3005048 and https://www.drupal.org/project/domain_site_settings/issues/2930391
Can you check those if it helps you out ? Tnx

I am getting a similar error during config import or when I try to uninstall a module with drush pmu, however the domain module is not in the trace here, but eca. So probably this is rather something actually within the fastly module. The proposed patch solves the problem for me.

In Container.php line 149:

  Circular reference detected for service "Drupal\Core\Logger\LoggerChannelFactoryInterface", path: "plugin.cache_clearer -> plugin.manager.block -> logger.channel.defa
  ult -> Drupal\Core\Logger\LoggerChannelFactoryInterface -> logger.filelog -> eca.service.token -> cache_tags.invalidator -> fastly.cache_tags.invalidator -> fastly.ap
  i -> logger.channel.fastly".


Failed to log error: Symfony\Component\DependencyInjection\Exception\ServiceCircularReferenceException: Circular reference detected for service "Drupal\Core\Logger\LoggerChannelFactoryInterface", path: "purge.purgers -> purge.logger -> Drupal\Core\Logger\LoggerChannelFactoryInterface -> logger.filelog -> eca.service.token -> cache_tags.invalidator -> fastly.cache_tags.invalidator -> fastly.api -> logger.channel.fastly". in Drupal\Component\DependencyInjection\Container->get() (line 149 of /var/www/html/docroot/core/lib/Drupal/Component/DependencyInjection/Container.php). #0 /var/www/html/docroot/core/lib/Drupal/Component/DependencyInjection/Container.php(438): Drupal\Component\DependencyInjection\Container->get()

Just hit another version of this:
Circular reference detected for service "fastly.api", path: "fastly.api -> fastly.services.webhook -> Drupal\menu_link_content\Hook\MenuLinkContentHooks -> plugin.manager.menu.link -> Drupal\Core\Menu\MenuTreeStorageInterface -> cache_tags.invalidator -> fastly.cache_tags.invalidator".

While testing 11.4. This patch solves it for me too.

Have raised this with Fastly via our partner relationship asking that it be merged and released, similar pattern we have performed with other minor updates in the past.