Closed (fixed)
Project:
Fastly
Version:
8.x-3.x-dev
Component:
Code
Priority:
Normal
Category:
Feature request
Assigned:
Issue tags:
Reporter:
Created:
28 Sep 2016 at 23:53 UTC
Updated:
14 Mar 2017 at 15:34 UTC
Jump to comment: Most recent, Most recent file
Comments
Comment #2
jan.stoecklerLet's see if this does the job.
Comment #3
jan.stoecklerMissed some files for the patch.
Comment #4
jan.stoecklerComment #5
jan.stoecklerSorry for the confusion. This should work.
Comment #6
jan.stoecklerPatch seems to be working nicely, setting this to needs review.
Comment #7
marvin_b8 commentedComment #8
gábor hojtsyComment #9
vijaycs85Thanks for working on this issue @jan.stoeckler. Here is my review.
minor: Remove space
IMHO, we should Surrogate-Control header instead of Cache-Control. This way, we don't change the default behaviour. Ref: https://docs.fastly.com/guides/tutorials/cache-control-tutorial#when-cac...
Comment #10
jan.stoecklerThanks @vijaycs85 for your review, I'll get right on that.
Comment #11
vijaycs85Thanks @jan.stoeckler. updating status accordingly.
Comment #12
jan.stoecklerSorry for taking so long, here it is.
Comment #13
jan.stoecklerAnd a small correction.
Comment #14
jan.stoecklerStatus update.
Comment #15
jan.stoecklerAnd another correction.
Comment #16
jan.stoecklerFix another misguided attempt.
Comment #17
vijaycs85Thanks for the updates @jan.stoeckler. It looks good.
Comment #18
vijaycs85Can we get this in please? It's been in RTBC for a while.
Comment #19
leon kessler commentedSorry for the delay....
I believe the Fastly team were going to be maintaining this module. I was the maintainer of the D7 version, but can help out with the D8 version too.
Patch looks good, just one thing that looks odd....
Should this be removed or uncommented?
Comment #20
vijaycs85@Leon Kessler, sure, would you mind apply patch and remove the commented line? We can issue another patch without that line, but it's not that great chance. can go as part of commit.
Comment #22
leon kessler commentedOkay pushed to dev.
Tried to create a 8.x-3.1 release as well, but I do not have sufficient privileges.
Comment #23
vijaycs85awesome! thank you @Leon Kessler.