Problem/Motivation

Per our discussion at DrupalCon Los Angeles, I'm porting this to Drupal 8.

Proposed resolution

Use the X-Drupal-Cache-Tags header, map it to a Surrogate-Key header.

Remaining tasks

For follow-up issues:

  1. Better API error handling (but it's better than the D7 module already).
  2. Surrogate-Control header (but it should probably just obey Drupal 8's Cache-Control headers, since this is contentious, I haven't added it yet)
  3. Test coverage (was none in D7 either).

User interface changes

Removed:

  1. purging UI: pretty much completely pointless now, just use the Fastly.com UI
  2. registration UI (could be added again, but this is simpler, and it was implemented pretty poorly)
  3. service addition UI (could be added again, but this is simpler, and it was implemented pretty poorly)

API changes

None.

CommentFileSizeAuthor
#2 fastly-d8-2491561-2.patch41.1 KBWim Leers
#1 fastly-d8-2491561-1.patch40.89 KBWim Leers
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

Wim Leers’s picture

Wim Leers
Location Ghent 🇧🇪🇪🇺
CreditAttribution: Wim Leers at Acquia commented
Issue summary: View changes
Status: Active » Needs review
FileSize
fastly-d8-2491561-1.patch40.89 KB
Wim Leers’s picture

Wim Leers
Location Ghent 🇧🇪🇪🇺
CreditAttribution: Wim Leers at Acquia commented
Issue summary: View changes
FileSize
fastly-d8-2491561-2.patch41.1 KB

And voila. I consider this done. The rest can be done in follow-up issues.

Fabianx’s picture

Fabianx CreditAttribution: Fabianx as a volunteer and at Tag1 Consulting commented
Status: Needs review » Needs work 
+++ b/src/Form/FastlySettingsForm.php
@@ -0,0 +1,141 @@
+ * This is the GlobalRedirect admin include which provides an interface to global redirect to change some of the default settings
+ * Contains \Drupal\globalredirect\Form\GlobalredirectSettingsForm.

This looks like a copy pasta error ...

Except the c&p error, this looks great to me :).

Leon Kessler’s picture

Leon Kessler CreditAttribution: Leon Kessler commented

I've created a 8.x-1.x and attached patch from #2

You may want to contact the module owner to get write permissions to the project, I don't think I can add you.

Would also love to help testing this out, although may take me a while to get a D8 environment with Fastly setup.

Wim Leers’s picture

Wim Leers
Location Ghent 🇧🇪🇪🇺
CreditAttribution: Wim Leers at Acquia commented

@leon.nk: Oh, wow, that must be the fastest commit ever! :D Thank you!

Contacted the project owner, asked him to make DocWilco (https://www.drupal.org/u/drwilco) the new owner.

moshe weitzman’s picture

moshe weitzman CreditAttribution: moshe weitzman at Acquia commented

Would be good to update the Project page since this module has changed a bit in 8.x

Wim Leers’s picture

Wim Leers
Location Ghent 🇧🇪🇪🇺
CreditAttribution: Wim Leers at Acquia commented
Related issues: +#2542868: Allow a header value size limit to be specified

We're now looking to port part of this to D8 core: #2542868: Allow a header value size limit to be specified.

  • bbbb750 committed on 8.x-3.x 
    Issue #2491561 by balatin, polynya, landing: Port to Drupal 8
balatin’s picture

balatin CreditAttribution: balatin as a volunteer commented
Status: Needs work » Closed (fixed)

A new 8.x-3.0-alpha1 release has been created. Please add new bug fixes, security updates, and feature requests to the issue queue.