Hi all,

I was hoping that fastclick could support versioning regex so that the version would be a number readable by Libraries API. This would allow services like CDNs to use this numeric version to pull down the same local version of the fastclick.js file to be used on a drupal site. I've supplied a patch that does version matching in the js file to pull the correct version down. Please let me know if you have any questions.

Thank you for your time,
Mark Milutinovic

CommentFileSizeAuthor
#2 add_version_regex-2755133-2.patch642 bytesmmilutinovic1313
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

mmilutinovic1313 created an issue. See original summary.

mmilutinovic1313’s picture

Pere Orga’s picture

Assigned: mmilutinovic1313 » Unassigned
Status: Active » Needs review

Thanks for the patch (updating status)

Pere Orga’s picture

Status: Needs review » Fixed

Applied, thanks!

mitche42’s picture

After updating the FastClick module with this patch I get the warning message "Error loading FastClick Library." I suspect something in this patch is not working.

Pere Orga’s picture

Status: Fixed » Active

I could not reproduce, but to be safe I've reverted the patch and released 7.x-1.5

  • Pere Orga committed fb3c84f on 7.x-1.x
    Revert "Issue #2755133 by mmilutinovic1313: Add Versioning Regex"
    
    This...
mitche42’s picture

I tried to find a fix but ended up hacking it with a reversion as well. Your reversion (update 1.5) works for me.

Pere Orga’s picture

Status: Active » Closed (outdated)