Currently, Fast404 only listens to KernelRequest event. If a user hits a valid path, but another module intervenes and returns a NotFoundHttpException exception (eg. m4032404 module), the native Drupal 404 page is returned instead of the Fast404 page.

Fast404 Event subscriber should also listen to the NotFoundHttpException event to completely replace Drupal 404 page.

CommentFileSizeAuthor
#12 fast_404-subscribe_notfound_exception-2930381-12.patch2.69 KBgg4
#12 interdiff--2930381-4-12.txt2.22 KBgg4
#4 fast_404-subscribe_notfound_exception-2930381-4.patch1.57 KBsonnykt
#2 fast_404-subscribe_notfound_exception-2930381-1.patch1.57 KBsonnykt
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

sonnykt created an issue. See original summary.

sonnykt’s picture

sonnykt
Location Melbourne, Australia
CreditAttribution: sonnykt at Salsa Digital commented
FileSize
fast_404-subscribe_notfound_exception-2930381-1.patch1.57 KB
sonnykt’s picture

sonnykt
Location Melbourne, Australia
CreditAttribution: sonnykt at Salsa Digital commented
Issue summary: View changes
sonnykt’s picture

sonnykt
Location Melbourne, Australia
CreditAttribution: sonnykt at Salsa Digital commented
FileSize
fast_404-subscribe_notfound_exception-2930381-4.patch1.57 KB

This patch lowers the priority of the listener so that it works if another module (eg. m4032404) changes the exception type to NotFoundHttpException.

gargsuchi’s picture

gargsuchi CreditAttribution: gargsuchi at Salsa Digital for Department of Premier and Cabinet - Victoria, Australia commented
Status: Active » Needs review
sonnykt’s picture

sonnykt
Location Melbourne, Australia
CreditAttribution: sonnykt at Salsa Digital commented
Version: 8.x-1.0-alpha2 » 8.x-1.x-dev
sonnykt’s picture

sonnykt
Location Melbourne, Australia
CreditAttribution: sonnykt at Salsa Digital commented
gg4’s picture

gg4 CreditAttribution: gg4 commented
Assigned: sonnykt » Unassigned

Unassigned since there is a patch to review.

gg4’s picture

gg4 CreditAttribution: gg4 commented
Status: Needs review » Reviewed & tested by the community

This seems like really nice improvement. Thinking about this, we probably should gate this behind a new setting, as is the precedent for the other features of this module.

gg4’s picture

gg4 CreditAttribution: gg4 commented
Status: Reviewed & tested by the community » Needs work
gg4’s picture

gg4 CreditAttribution: gg4 commented
Status: Needs work » Reviewed & tested by the community

Thinking about this more, if we are not gating the main onKernelRequest event subscriber, probably not a reason to gate onNotFoundException behind a $setting.

gg4’s picture

gg4 CreditAttribution: gg4 commented
Status: Reviewed & tested by the community » Needs review
FileSize
interdiff--2930381-4-12.txt2.22 KB
fast_404-subscribe_notfound_exception-2930381-12.patch2.69 KB
sonnykt’s picture

sonnykt
Location Melbourne, Australia
CreditAttribution: sonnykt at Salsa Digital commented
Status: Needs review » Reviewed & tested by the community

  • bonus committed 8eee40f on 8.x-1.x authored by sonnykt 
    Issue #2930381 by sonnykt, bonus: Subscribe to NotFoundHttpException...
gg4’s picture

gg4 CreditAttribution: gg4 commented
Status: Reviewed & tested by the community » Fixed

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.