Hi,
Thank you for D8 version of this fantastic module. I wanted to make a suggestions for making it easier to integrate this module into a drupal site.

1) I suggest we move "default & suggested settings" config to a dedicated settings file instead of readme. maybe something like example.settings.fast404.php.

2) This file can then be included into the main settings.php file, something like.

/**
 * Load fast404 configuration, if available.
 *
 * Use settings.fast404.php to provide settings for Fast404 module
 *
 * Keep this code block at the end of this file to take full effect.
 */
#
# if (file_exists($app_root . '/' . $site_path . '/settings.fast404.php')) {
#   include $app_root . '/' . $site_path . '/settings.fast404.php';
# }

Any thoughts on this approach?

Support from Acquia helps fund testing for Drupal Acquia logo

Comments

dakku created an issue. See original summary.

dakku’s picture

dakku’s picture

Issue summary: View changes
dakku’s picture

Status: Active » Needs review
gg4’s picture

Additional cleanup and code standards fixes to match Drupal's setting.php more closely.

gg4’s picture

Status: Needs review » Needs work

The last submitted patch, 6: interdiff--fast404-2904358--5-6.diff, failed testing. View results

  • bonus committed df43b75 on 8.x-1.x
    Issue #2904358 by bonus, dakku: Moving default settings config to a...
gg4’s picture

Status: Needs work » Fixed

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.