Support for Drupal 7 is ending on 5 January 2025—it’s time to migrate to Drupal 10! Learn about the many benefits of Drupal 10 and find migration tools in our resource center.
Hi,
Thank you for D8 version of this fantastic module. I wanted to make a suggestions for making it easier to integrate this module into a drupal site.
1) I suggest we move "default & suggested settings" config to a dedicated settings file instead of readme. maybe something like example.settings.fast404.php.
2) This file can then be included into the main settings.php file, something like.
/**
* Load fast404 configuration, if available.
*
* Use settings.fast404.php to provide settings for Fast404 module
*
* Keep this code block at the end of this file to take full effect.
*/
#
# if (file_exists($app_root . '/' . $site_path . '/settings.fast404.php')) {
# include $app_root . '/' . $site_path . '/settings.fast404.php';
# }
Any thoughts on this approach?
Comment | File | Size | Author |
---|---|---|---|
#6 | interdiff--fast404-2904358--5-6.diff | 5.8 KB | gg4 |
#6 | fast404-2904358-6.patch | 13.97 KB | gg4 |
Comments
Comment #2
dakku CreditAttribution: dakku as a volunteer commentedComment #3
dakku CreditAttribution: dakku as a volunteer commentedComment #4
dakku CreditAttribution: dakku as a volunteer commentedComment #5
gg4 CreditAttribution: gg4 commentedAdditional cleanup and code standards fixes to match Drupal's setting.php more closely.
Comment #6
gg4 CreditAttribution: gg4 commentedComment #9
gg4 CreditAttribution: gg4 commented