On the FAQ Config page (admin/config/content/faq), the Title field should set the title at the top of the FAQ page. It does not.

I have a custom path set: about/faq. Title is set to "Frequently Asked Questions". But if you visit about/faq, the title that displays is simply "FAQ". I see no other place to change it, which suggests that this may be a bug.

CommentFileSizeAuthor
#6 changes_to_title_on_config_page_are_ignored-2971082-6.patch510 bytesespurnes
#2 Issue_#2971082.patch524 bytesaurelianzaha

Comments

bondjimbond created an issue. See original summary.

aurelianzaha’s picture

aurelianzaha commented
StatusFileSize
new Issue_#2971082.patch524 bytes

Hi,

II found a small bug causing the issue, I am submitting a patch for it.

regards
Aurelian

aurelianzaha’s picture

aurelianzaha commented
Status: Active » Needs review
espurnes’s picture

espurnes
Primary language Catalan
commented

working with this module I've found the same bug.

I think you can remove the first part of the OR. Changing this code:

if (arg(0) == 'faq-page' or variable_get('faq_path', 'faq-page')) {
     drupal_set_title(t(variable_get('faq_title', 'Frequently Asked Questions')));
   }

by

if (arg(0) == variable_get('faq_path', 'faq-page')) {
     drupal_set_title(t(variable_get('faq_title', 'Frequently Asked Questions')));
   }

variable_get will return faq-page if faq_path is not set. So, no need to have the "or".

aurelianzaha’s picture

aurelianzaha commented

good point espurnes!

espurnes’s picture

espurnes
Primary language Catalan
commented
StatusFileSize
new changes_to_title_on_config_page_are_ignored-2971082-6.patch510 bytes

Added patch with the suggested change on #4.

andrey.troeglazov’s picture

andrey.troeglazov commented
Issue tags: +FAQ Release 7.x-1.2

andrey.troeglazov’s picture

andrey.troeglazov commented
Status: Needs review » Fixed

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.