Just ran the update to version 7.x-1.1 and now my sitemap (https://www.drupal.org/project/site_map 7.x-1.3) gives this error:

Notice: Undefined property: stdClass::$question in faq_get_faq_list() (line 1137 of /var/www/infosites/public_html/sites/all/modules/faq/faq.module).
Notice: Undefined property: stdClass::$question in faq_get_faq_list() (line 1137 of /var/www/infosites/public_html/sites/all/modules/faq/faq.module).
Notice: Undefined property: stdClass::$question in faq_get_faq_list() (line 1137 of /var/www/infosites/public_html/sites/all/modules/faq/faq.module).
Notice: Undefined property: stdClass::$question in faq_get_faq_list() (line 1137 of /var/www/infosites/public_html/sites/all/modules/faq/faq.module).
Notice: Undefined property: stdClass::$question in faq_get_faq_list() (line 1137 of /var/www/infosites/public_html/sites/all/modules/faq/faq.module).
Notice: Undefined property: stdClass::$question in faq_get_faq_list() (line 1137 of /var/www/infosites/public_html/sites/all/modules/faq/faq.module).

And the FAG items in the sitemap are empty (see screenshot 2)

CommentFileSizeAuthor
#3 undefined-property-2568685-3.patch350 bytesprashant.c
Knipsel_02.PNG13.75 KBneorg
Knipsel_01.PNG65.59 KBneorg

Comments

neorg created an issue. See original summary.

neorg’s picture

neorg commented

SOLVED!

Change line 1173 from /modules/faq/faq.module

$items[] = l($node->question, "node/$node->nid");
to
$items[] = l($node->title, "node/$node->nid");

So this loop 

foreach ($nodes as $node) {
    if (node_access('view', $node)) {
      $items[] = l($node->question, "node/$node->nid");
    }
  }

changes to this:

foreach ($nodes as $node) {
    if (node_access('view', $node)) {
      $items[] = l($node->title, "node/$node->nid");
    }
  }

Please apply this in the module

prashant.c’s picture

prashant.c
he/him
Primary language English
Location Dharamshala
commented
Status: Active » Needs review
StatusFileSize
new undefined-property-2568685-3.patch350 bytes

Submitting patch for changes suggested by #2.

Same needs to be reviewed.

andrey.troeglazov’s picture

andrey.troeglazov commented
Issue tags: -site map +FAQ Release 7.x-1.2
andrey.troeglazov’s picture

andrey.troeglazov commented
Status: Needs review » Fixed

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.