Problem/Motivation

We're using the facets_pretty_paths module, and it will be great if this module supports it.

Issue fork facets_reset_button-3244735

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

About issue forks
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

facine created an issue. See original summary.

facine opened merge request !1

facine’s picture

facine CreditAttribution: facine as a volunteer and at Cambrico commented
Status: Active » Needs review

I've created a MR adding support to facets_pretty_paths and removing the js library dependency, I thing we can use the blockAccess method to determine if the block should be visible or not.

Anybody’s picture

Anybody
Primary language German
Location Porta Westfalica
CreditAttribution: Anybody at DROWL.de commented

@facine that fix looks great and cleans up the module a lot! Did you already test it without using facets_pretty_paths?

Sadly this module has no test coverage, so we can't see if it break anything. From code side, definitely RTBC+1!

Anybody’s picture

Anybody
Primary language German
Location Porta Westfalica
CreditAttribution: Anybody at DROWL.de commented

Yeah just tried this (but with facets_pretty_paths) and it simply works perfect! Makes the module work with facets_pretty_paths, slim and robust! Great work!

If the maintainer can confirm this works without facets_pretty_paths this should definitely be committed asap!

Anybody’s picture

Anybody
Primary language German
Location Porta Westfalica
CreditAttribution: Anybody at DROWL.de commented

@facine I just had a short try without facets_pretty_path and it looks as it sadly doesn't work yet. The "Reset" button simply doesn't appear. But someone else should also test this, perhaps I made a mistake.

@facine could you have a look to make it work in general?