Problem/Motivation

Fix PHPCS issues reported on CI/gitlab.

Issue fork facets-3502922

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

About issue forks

Comments

herved created an issue. See original summary.

herved changed the visibility of the branch phpcs to hidden.

herved opened merge request !281

herved’s picture

herved commented
Status: Active » Needs review

herved changed the visibility of the branch phpcs to active.

herved changed the visibility of the branch phpcs to hidden.

joseph.olstad’s picture

joseph.olstad
Primary language French
commented
Status: Needs review » Reviewed & tested by the community

This one is actually simpler to understand than #3502957: Fix PHPStan issues reported on CI/gitlab
Looks good, phpunit tests passing.

  • strykaizer committed 4800c738 on 3.0.x authored by herved 
    [#3502922] fix: Fix PHPCS issues reported on CI/gitlab

By: herved
By:...
strykaizer’s picture

strykaizer
Primary language Dutch
Location Belgium
commented
Status: Reviewed & tested by the community » Fixed

Now that this issue is closed, please review the contribution record.

As a contributor, attribute any organization that helped you, or if you volunteered your own time.

Maintainers, please credit people who helped resolve this issue.

strykaizer’s picture

strykaizer
Primary language Dutch
Location Belgium
commented
Issue tags: +Vienna2025
liam morland’s picture

liam morland
Primary language English
Location Ontario, CA 🇨🇦
commented
Status: Fixed » Active

phpcs still raises issues.

liam morland opened merge request !342

liam morland’s picture

liam morland
Primary language English
Location Ontario, CA 🇨🇦
commented
Status: Active » Needs review

With the changes in this merge request, phpcs passes.

strykaizer’s picture

strykaizer
Primary language Dutch
Location Belgium
commented
Status: Needs review » Fixed

Thx!

Now that this issue is closed, please review the contribution record.

As a contributor, attribute any organization that helped you, or if you volunteered your own time.

Maintainers, please credit people who helped resolve this issue.

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.