Problem/Motivation

\Drupal\Tests\facets\Kernel\FacetManager\DefaultFacetManagerTest has a custom assertion method to compare Cacheability arrays. However, typically these are tested using PHPUnit's own assertEqualsCanonicalizing

Proposed resolution

Replace custom assertCacheabillityArrays with PHPUnit's assertEqualsCanonicalizing

Remaining tasks

  1. Write a patch
  2. Review
  3. Commit

User interface changes

None.

API changes

None.

Data model changes

None.

Issue fork facets-3327629

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

About issue forks

Comments

idebr created an issue. See original summary.

idebr opened merge request !119

idebr’s picture

idebr commented
Status: Active » Needs review

The merge request replaces the custom assertCacheabillityArrays with PHPUnit's assertEqualsCanonicalizing

mkalkbrenner’s picture

mkalkbrenner
Primary language German
Location 🇩🇪
commented

I guess, it applies to 2.0.x as well, right?

idebr’s picture

idebr commented

Yes, the suggested change applies to both 3.0.x and 2.0.x

  • mkalkbrenner committed f8678e9c on 3.0.x 
    Issue #3327629: Replace custom assertCacheabillityArrays with PHPUnit's...

  • mkalkbrenner committed d4fc586b on 2.0.x 
    Issue #3327629: Replace custom assertCacheabillityArrays with PHPUnit's...
mkalkbrenner’s picture

mkalkbrenner
Primary language German
Location 🇩🇪
commented
Status: Needs review » Fixed

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.