D9.0.1 + Search Api 8.x-1.18 + Facets latest .dev

Slider is not showing up.

Console errors for both slider and slider ranges:

jquery-ui-slider-pips.min.js?v=1.11.3:4

Uncaught TypeError: Cannot read property 'prototype' of undefined
    at jquery-ui-slider-pips.min.js?v=1.11.3:4
    at jquery-ui-slider-pips.min.js?v=1.11.3:4
(anonymous) @ jquery-ui-slider-pips.min.js?v=1.11.3:4
(anonymous) @ jquery-ui-slider-pips.min.js?v=1.11.3:4

drupal.js?v=9.1.0:16

Uncaught TypeError: Cannot read property '0' of undefined
    at Object.Drupal.facets.addSlider (slider.js?v=9.1.0:39)
    at Object.<anonymous> (slider.js?v=9.1.0:16)
    at Function.each (jquery.min.js?v=3.5.1:2)
    at Object.attach (slider.js?v=9.1.0:15)
    at drupal.js?v=9.1.0:27
    at Array.forEach (<anonymous>)
    at Object.Drupal.attachBehaviors (drupal.js?v=9.1.0:24)
    at HTMLUListElement.<anonymous> (checkbox-widget.js?v=9.1.0:39)
    at Function.each (jquery.min.js?v=3.5.1:2)
    at a.fn.init.each (jquery.min.js?v=3.5.1:2)
Drupal.facets.addSlider @ slider.js?v=9.1.0:39
(anonymous) @ slider.js?v=9.1.0:16
each @ jquery.min.js?v=3.5.1:2
attach @ slider.js?v=9.1.0:15
(anonymous) @ drupal.js?v=9.1.0:27
Drupal.attachBehaviors @ drupal.js?v=9.1.0:24
(anonymous) @ checkbox-widget.js?v=9.1.0:39
each @ jquery.min.js?v=3.5.1:2
each @ jquery.min.js?v=3.5.1:2
Drupal.facets.makeCheckboxes @ checkbox-widget.js?v=9.1.0:26
attach @ checkbox-widget.js?v=9.1.0:13
(anonymous) @ drupal.js?v=9.1.0:27
Drupal.attachBehaviors @ drupal.js?v=9.1.0:24
(anonymous) @ drupal.init.js?v=9.1.0:29
listener @ drupal.init.js?v=9.1.0:17

drupal.js?v=9.1.0:16

Uncaught TypeError: Cannot read property '0' of undefined
    at Object.Drupal.facets.addSlider (slider.js?v=9.1.0:39)
    at Object.<anonymous> (slider.js?v=9.1.0:16)
    at Function.each (jquery.min.js?v=3.5.1:2)
    at Object.attach (slider.js?v=9.1.0:15)
    at drupal.js?v=9.1.0:27
    at Array.forEach (<anonymous>)
    at Object.Drupal.attachBehaviors (drupal.js?v=9.1.0:24)
    at drupal.init.js?v=9.1.0:29
    at HTMLDocument.listener (drupal.init.js?v=9.1.0:17)
Drupal.facets.addSlider @ slider.js?v=9.1.0:39
(anonymous) @ slider.js?v=9.1.0:16
each @ jquery.min.js?v=3.5.1:2
attach @ slider.js?v=9.1.0:15
(anonymous) @ drupal.js?v=9.1.0:27
Drupal.attachBehaviors @ drupal.js?v=9.1.0:24
(anonymous) @ drupal.init.js?v=9.1.0:29
listener @ drupal.init.js?v=9.1.0:17
CommentFileSizeAuthor
#23 3186953_23.patch1.87 KBmkalkbrenner
#21 3186953_21.patch2.29 KBmkalkbrenner
#17 slider-facet-js-error-3186953-17.patch1.72 KBrenrhaf
#8 3186953--7.patch1.73 KBlukasss
#6 3186953--6.patch1.71 KBlukasss

Issue fork facets-3186953

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

About issue forks

Comments

devad created an issue. See original summary.

devad’s picture

devad commented
Issue summary: View changes
devad’s picture

devad commented
Issue summary: View changes
lukasss’s picture

lukasss commented

I have similar problems too.
I think this is due to the lack of necessary libraries jquery ui:
https://git.drupalcode.org/project/facets/-/blob/8.x-1.x/modules/facets_...
https://git.drupalcode.org/project/facets/-/blob/8.x-1.x/modules/facets_...

https://www.drupal.org/node/3067969

lukasss’s picture

lukasss commented
Priority: Normal » Critical
lukasss’s picture

lukasss commented
StatusFileSize
new 3186953--6.patch1.71 KB

I added jquery_ui_slider and jquery_ui_touch_punch in suggest section composer.json

lukasss’s picture

lukasss commented
Status: Active » Needs review
lukasss’s picture

lukasss commented
StatusFileSize
new 3186953--7.patch1.73 KB

some correct

The last submitted patch, 6: 3186953--6.patch, failed testing. View results

Status: Needs review » Needs work

The last submitted patch, 8: 3186953--7.patch, failed testing. View results

renrhaf’s picture

renrhaf
Primary language French
Location 📍 Strasbourg 🐦🦜
commented

+1 RTBC for patch #8.
Test is failing, does someone know how to get rid of that ? Just add the "jquery_ui_slider" module to the install list of the test case ?

idiaz.roncero’s picture

idiaz.roncero
he/him
Primary language Spanish
Location Madrid
commented

+1, the module range slider won't work on D9 due to jquery.ui.slider removed from Core

james.williams’s picture

james.williams
Location Coventry, UK
commented
Related issues: +#3153622: Offer an alternative slider based on nouislider for Facets Range Widget
marcoka’s picture

marcoka commented

Yep, same here :)
"Uncaught TypeError: $(...).slider is not a function"

jonathan_hunt made their first commit to this issue’s fork.

jonathan_hunt opened merge request !31

renrhaf’s picture

renrhaf
Primary language French
Location 📍 Strasbourg 🐦🦜
commented
StatusFileSize
new slider-facet-js-error-3186953-17.patch1.72 KB

Rerolled for 2.x branch

roland.molnar’s picture

roland.molnar commented

Patch in #17 worked for me.

anybody’s picture

anybody
Primary language German
Location Porta Westfalica
commented
Version: 8.x-1.x-dev » 2.0.x-dev
Status: Needs work » Needs review
anybody’s picture

anybody
Primary language German
Location Porta Westfalica
commented

Patch looks good and makes a lot of sense against 2.x branch due to jQuery removal.

But this seems to be a duplicate of #3153622: Offer an alternative slider based on nouislider for Facets Range Widget?

Perhaps close this issue and proceed in 3153622 as it seems more complete? Which one contains the better patch?

mkalkbrenner’s picture

mkalkbrenner
Primary language German
Location 🇩🇪
commented
Component: Search API integration » Code
StatusFileSize
new 3186953_21.patch2.29 KB

Status: Needs review » Needs work

The last submitted patch, 21: 3186953_21.patch, failed testing. View results

mkalkbrenner’s picture

mkalkbrenner
Primary language German
Location 🇩🇪
commented
Status: Needs work » Needs review
StatusFileSize
new 3186953_23.patch1.87 KB

  • mkalkbrenner committed 768ed43 on 2.0.x 
    Issue #3186953 by lukasss, mkalkbrenner, jonathan_hunt, Renrhaf, Anybody...
mkalkbrenner’s picture

mkalkbrenner
Primary language German
Location 🇩🇪
commented
Status: Needs review » Fixed

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.