Closed (fixed)
Project:
Facets
Version:
8.x-1.x-dev
Component:
Code
Priority:
Normal
Category:
Feature request
Assigned:
Unassigned
Issue tags:
Reporter:
Created:
21 Feb 2019 at 22:06 UTC
Updated:
16 Nov 2020 at 06:39 UTC
Jump to comment: Most recent, Most recent file
Comments
Comment #2
borisson_This looks really cool!
A novice could upload a patch here to add this project to the readme.txt, similar to what happened over in #3006950.
Comment #3
alexandersluiter commentedNo need for any of the other patches now that the Javascript API is coming together. This small patch is all that's needed in order to tell the JS API to skip updating the range input form blocks.
Comment #4
alexandersluiter commentedComment #5
borisson_Ok so that means we're probably should commit this small change. I will create a new issue for the readme.txt update.
Comment #6
borisson_Go testbot, go!
Comment #7
borisson_The readme update can go in #3054542: Add documentation about the facets_range_input module
Comment #8
geek-merlinComment #9
heddnBump
Comment #11
borisson_@heddn: Was that a reminder to commit this, or something else? Setting to rtbc is a more effective indicator of that.
In any case, I totally forgot about this issue. I committed #4.
Comment #12
dench0The last commit can break view ajax executing if
drupalSettings.facetsisundefined.For example, on page exist only
List of linkswidget withsoft_limit = 0. In this casedrupalSettings.facetsis absent and this checking will trow aTypeErrorwith message"settings.facets is undefined".Comment #14
borisson_