Int to string comparison when setting active results [#2938736]

Under certain circumstances the a result's raw value is an integer when the active values that it is compared with are strings. That results in the comparison to fail.

if (in_array($result->getRawValue(), $this->active_values)) {

The patches casts the raw value to string before making the comparison and that fixes the issue.

Comment	File	Size	Author
#2	2938736-int-to-string-comparison-fix-2.patch	578 bytes	krystalcode

Support from Acquia helps fund testing for Drupal Acquia logo

Comments

Comment #1

23 January 2018 at 01:31

krystalcode created an issue. See original summary.

Comment #2

krystalcode CreditAttribution: krystalcode at Acro Commerce commented 23 January 2018 at 01:31

Status:

Active

» Needs review

File	Size
2938736-int-to-string-comparison-fix-2.patch	578 bytes

Patch attached.

Comment #3

borisson_

Dutch

Mechelen, 🇧🇪

CreditAttribution: borisson_ as a volunteer commented 23 January 2018 at 12:10

That's weird, because in_array doesn't do strict matching by default, and we haven't overwritten the $strict parameter. Do you happen to have a testcase where this fails?

Comment #4

borisson_

Dutch

Mechelen, 🇧🇪

CreditAttribution: borisson_ as a volunteer commented 17 February 2018 at 09:10

Status:

Needs review

» Needs work

I don't see any reason why this would make any difference. See also: https://3v4l.org/CR5Ze

Comment #5

krystalcode CreditAttribution: krystalcode at Acro Commerce commented 20 February 2018 at 01:47

I know, it was really weird. It was happening on a price facet widget. It could be some weird PHP bug, I don't know. If I ever get some time I'll try to reproduce.